Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GFSv16 dzmin change and changes for Dev/jcsda #44

Merged
merged 4 commits into from
Nov 17, 2020

Conversation

junwang-noaa
Copy link
Collaborator

@junwang-noaa junwang-noaa commented Oct 28, 2020

  1. Bring GFS.v16 dycore changes back to dev/emc branch
  2. the dycore changes for dev/jcsda in PR Dev/jcsda #35
  3. Remove the duplicate use fms_mod, only: read_data in tools/external_ic.F90 (issue #45)

Associated PR:

dycore PR #44
fv3atm PR #196
ufs-weather-model PR #274

@junwang-noaa
Copy link
Collaborator Author

Dan, I combined your dycore#35 in this PR. Please check.

@junwang-noaa
Copy link
Collaborator Author

RT test showed dzmin change has no impact on current baseline, as Lucas expected.

@junwang-noaa junwang-noaa changed the title add GFSv16 dzmin change add GFSv16 dzmin change and changes for Dev/jcsda Nov 12, 2020
Copy link

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not named as a reviewer, but it works for me when running the regression tests on hera.{intel,gnu} and cheyenne.{intel,gnu}.

@junwang-noaa junwang-noaa merged commit 6187585 into NOAA-EMC:dev/emc Nov 17, 2020
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/GFDL_atmos_cubed_sphere that referenced this pull request Mar 15, 2021
* add GFSv16 dzmin change
* Add code changes in external_ic.F90 and fv_grid_tools.F90 for dev/jcsda, dycore PR NOAA-EMC#35

Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Co-authored-by: Dan Holdaway <dan.holdaway@nasa.govr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants