Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate use fms_mod, only: read_data in tools/external_ic.F90 #45

Closed
snebuda opened this issue Nov 13, 2020 · 4 comments
Closed

Duplicate use fms_mod, only: read_data in tools/external_ic.F90 #45

snebuda opened this issue Nov 13, 2020 · 4 comments

Comments

@snebuda
Copy link

snebuda commented Nov 13, 2020

FV3/atmos_cubed_sphere/tools/external_ic.F90 has a duplicate statement for
use fms_mod, only: read_data

When I complied with intel 18.0.3 on UW-Madison S4, the duplicate use statement caused the generic interface for read_data to fail while reading the gfs_ctrl.nc vcoord 2d data field. It incorrectly used the read_data_3d_new routine.

FATAL from PE 7: fms_io(read_data_3d_new), field vcoord in file INPUT/gfs_ctrl.nc: field size mismatch 1

Removing the duplicate statement and recompiling stopped this fatal error.

@junwang-noaa
Copy link
Collaborator

@snebuda Thanks for letting us know this error and the fix. I added the fix in PR#44 . It will be committed to the repository next week.

@snebuda
Copy link
Author

snebuda commented Nov 13, 2020

Great - Thanks Jun!
Sharon

@climbfuji
Copy link

Thanks, @snebuda - I also pulled the fix from @junwang-noaa into the ufs-release/public-v2 branch hosted at the NOAA-GFDL Github fork. See NOAA-GFDL#61.

@junwang-noaa
Copy link
Collaborator

The code is committed in PR#44, close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants