forked from ESCOMP/CMEPS
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMEPS for postphases, ice sheets and glc->ocn dynamic mapping #28
Merged
DeniseWorthen
merged 251 commits into
NOAA-EMC:emc/develop
from
DeniseWorthen:feature/updcmeps
Jan 12, 2021
Merged
Changes from all commits
Commits
Show all changes
251 commits
Select commit
Hold shift + click to select a range
b14b314
add wind speed field for HAFS app
uturuncoglu 4e7d049
change TFREEZE_SALTWATER_OPTION for MOM6
alperaltuntas 82613c5
change of cice ice temperature to be consistent with nems
bd2ecee
more changes to be consistent with updates to nems
70593ad
additional changes needed for consistency with nems as well of cleanu…
a2b83a2
cleanup of med.F90
1173f58
addition of more comments for datainitialize sequence
d84d11e
updated pull request template
0573b7e
changes requested in the PR
644ca58
changes requested in PR
aa668e9
Merge pull request #72 from alperaltuntas/change_tfreeze_saltwater_op…
jedwards4b 9ef8d65
fixed more PR issues
9376b87
Merge pull request #75 from ESCOMP/mvertens/nems_changes
jedwards4b 72ac794
update verbosity and profiling attributes to match with ESMF requirem…
uturuncoglu eb20102
fix to use HAFS yaml field dictionary
uturuncoglu 9a75154
make aoflux phase optional, default is still true
uturuncoglu 59ac2c5
clean field exchange file for HAFS app
uturuncoglu fba6d60
fix for ESMF verbosity attribute
uturuncoglu 2f70edb
do not need custom calculations for HAFS app
uturuncoglu 55f8f98
remove newly added Sa_wspd from CESM field dictionary
uturuncoglu 215cea7
remove newly added Sa_wspd from CESM field dictionary
uturuncoglu 9037506
add HAFS specific field dictionary
uturuncoglu 82712ad
Merge branch 'update_hafs' of https://github.com/ESCOMP/CMEPS into up…
uturuncoglu 130ad41
more fix for CMEPS verbosity and profiling
uturuncoglu 802dd3c
fix for ESMF verbosity and profiling
uturuncoglu 98f365b
Merge branch 'master' into update_hafs
uturuncoglu c5309aa
put extra control to coupling mode
uturuncoglu 58d78ba
add modify_via_xml to remaining verbosity and profiling variables
uturuncoglu 2a653f3
the debug code is removed
uturuncoglu 96053fb
fix run sequence for HAFS app
uturuncoglu 8277b32
remove nems_orig from conditional
uturuncoglu be77a06
Merge pull request #81 from ESCOMP/update_hafs
uturuncoglu d1d06c1
add missing fields to CESM field dictionary to work with ERA5
uturuncoglu b20e191
fix for FB diagnose using wrong bundle
DeniseWorthen a914eb9
fix for char initialization
jedwards4b 92ee47c
Merge remote-tracking branch 'escomp/master' into feature/updcmeps
DeniseWorthen a1f79f6
Merge branch 'bugfix/fbaccum' into feature/updcmeps
DeniseWorthen 593c526
reset if flags for debugging
DeniseWorthen dd8022c
white space change
DeniseWorthen d1632af
Update med.F90
DeniseWorthen cc416c2
minor clode cleanup
DeniseWorthen 46be10e
fix compile error
DeniseWorthen 4346117
remove more chk_err statements after LogWrites
DeniseWorthen 32a11a5
remove more chk_err statements after LogWrites
DeniseWorthen 3e1bde7
Merge pull request #94 from DeniseWorthen/feature/updcmeps
mvertens 7654038
fix pylint issues
jedwards4b 8646008
Fix CPP ESMF_VERSION_MAJOR and ESMF_VERSION_MINOR definitions.
danrosen25 8793896
Merge pull request #99 from danrosen25/fix/esmfversion
jedwards4b 07d3cab
remove custom merges for rain and snow
DeniseWorthen 51b19ac
new aliases in fd_nems.yaml
DeniseWorthen f68a3d2
combine fields exchange for nems orig/data; make corresponding
DeniseWorthen 54d8607
remove nems_data prep_ocn; make nems prep_ocn work for all nems modes
DeniseWorthen 1438b9d
fix coupling_mode if statement
DeniseWorthen 83bca27
prep ocn cleanup for datm
DeniseWorthen a6ece41
more consolidation in fields exchange
DeniseWorthen af0d961
white space
DeniseWorthen 9c17146
change method to find CIMEROOT
jedwards4b ff917af
Merge remote-tracking branch 'escomp/master' into feature/prepocn_cle…
DeniseWorthen 887c30e
fix hardcoded paths
jedwards4b 3c79b2c
fix hardcoded paths in buildexe
jedwards4b 32129aa
Merge pull request #103 from DeniseWorthen/feature/prepocn_cleanup
jedwards4b 72fdeec
fix copling mode issue
uturuncoglu b36a949
support multiple coupling mode for nems
uturuncoglu 01dfe9a
Merge pull request #104 from ESCOMP/fix_coupling_mode
uturuncoglu 3183506
bug fix for creation of ocean and ice fractions on atm mesh
f69e39c
Create extbuild.yml
jedwards4b 7b43058
cleanup of fix to map fractions
4ece277
more updates to fix nems problems
8ecdcc9
more updates for fraction calculation
e4b0b81
cmake and action without dir changes
jedwards4b 66a6b8f
Merge branch 'master' into add_cmake_and_github_actions
jedwards4b b7770f4
whitespace error fix
jedwards4b c2184a6
whitespace error fix
jedwards4b 513959e
fix path
jedwards4b 6962be0
populate pio submodule
jedwards4b cd9c7b3
add cmake helpers
jedwards4b 31e3c8d
fix error trapping in pylint script
jedwards4b 5bc3f22
fix pylint issue
jedwards4b afe65f9
try again
jedwards4b 3e858a9
fix whitespace
jedwards4b 9c9eac3
find netcdf.h
jedwards4b 715d7ba
remove python nightly - too extreme
jedwards4b 5c85a24
Merge pull request #109 from jedwards4b/add_cmake_and_github_actions
jedwards4b b9d6283
Merge branch 'master' into mvertens/bugfix_fractions
jedwards4b 5c79fb2
fix gnu compiler errors
jedwards4b 9965df1
updates to fix rof problem
f649a03
correct esmf error message
jedwards4b 42a992f
updates needed for nems
59a108a
updated med_fraction_mod to deal with I2000 bug
bfc2e9a
fixes to get I compset to work
c450625
improve error message
jedwards4b 1a5d830
Merge pull request #110 from ESCOMP/mvertens/bugfix_fractions
mvertens 298f84f
addition of water and energy global diagnostics
861e925
changes to get budgets working
a74c389
bug fixes and updates for cism
cf5da28
update of mvertens/newdiags
jedwards4b 9f697d5
budget development
jedwards4b fb8b42d
remove unused prevtime
jedwards4b 3515c71
add ocn budget for A compset
jedwards4b 91fccdc
budget improvements
jedwards4b ee63d5c
remove debug print statement
jedwards4b 04cf4d5
add netcdf to required for cmake
jedwards4b 1fec2df
fix netcdf case in cmake
jedwards4b 2b9a741
fix github build
jedwards4b c9a6b4e
fix github build
jedwards4b 9e59f18
fix github build
jedwards4b 263870e
fix github build
jedwards4b a9fc73a
fix github build
jedwards4b 6d1ebac
use master med_time_mod, remove shr_sys_abort
jedwards4b 0a28273
remove netcdf requirement from cmake build
jedwards4b c70410f
clean up wrt master
jedwards4b 88bd1f7
add back mesh_info
jedwards4b c7cdf6a
add back mesh_info
jedwards4b 9067ce0
more cleanup wrt master
jedwards4b 118db68
fixed problem with stop alarm initialization
7165848
add B1850 test, list SourceMods dir first in build
jedwards4b 3c1249a
Split esmFldsExchange_hafs_mod.F90 into advertise and initialize phases.
danrosen25 d390f6c
fix diags for c case
jedwards4b 96684bc
Merge pull request #107 from ESCOMP/jedwards/newdiags
mvertens 1bd8dd5
Merge pull request #114 from hafs-community/feature/hafs
uturuncoglu cc634da
add med_diag to Makefile
jedwards4b 026a6e7
make diags optional in the config file
jedwards4b 549616a
add error handling
jedwards4b 60b2397
remove set part
jedwards4b 176872c
dont get alarm options unless diags are set
jedwards4b 5c3bd48
makefile fix
jedwards4b 91fd48c
try this instead
jedwards4b db1869a
add interface
jedwards4b 7d5496c
Merge pull request #117 from jedwards4b/diags_optional_in_configfile
jedwards4b 61c7fde
fixed bug in mapping for flooding to ocn from river
bc6ced1
bug fixes
6aa22a1
fixed bug that was just introduced
a3790d5
remove albedo from the X compset
jedwards4b ac043a7
removed unneeded commented line
6934a89
Merge pull request #120 from ESCOMP/mvertens/fix_rofflooc
jedwards4b dda73e0
Merge pull request #119 from jedwards4b/remove_alb_xcompset
mvertens 5e6fcef
update PIO and genf90 to support CDEPS
2ba14ea
make internal PIO initialization optional for different UFS apps
c9e4ecb
fix GTPL issue and optional internal PIO initialization
850ddb8
Merge pull request #121 from ESCOMP/feature/hafs_cdeps_fixed
mvertens 4c23160
performance upgrade - primarily to med_merge_mod - on top of jedwards…
16962cd
updates to mapping to handle packed field bundles
237fd0f
major performance boosts for hard-wired packed redist
a05a7bb
updates to get packed field bundles for other mappings
2dac7b7
significantly improved the performance of the auto merge
2b82002
updates to have packed field bundles working in F compsets
6d0ccb6
fixes for f19_g17 F2000 tests
c3be8c6
more performance updates
bca5c05
introduced normalization routine that can also be reused in med_map_p…
ed7a721
hard-wired max profile for now
f696f41
updated mapping and med_phases_prep_rof_mod to using the new mapping …
a1b6b4a
updated med_map_prep_lnd_mod with new interface call for glc->lnd map…
38a9306
more updates to remove all references to old mapping
e59e71e
refactored now one normalization is handled
72ef815
updates to fix BMOM case
377a4cd
fixed bugs in testing
3690cb6
merge updates and cleanup of med_methods_mod
25a31da
undid debug settings that impacted performance
7540b4a
backed out some subname changes
c339bdc
made all local arrays initialized to null()
3d1e7df
removed DEBUG statements
f53d4bb
original code failed with rc2 error using gnu compiler
jedwards4b d093e64
Merge pull request #123 from jedwards4b/gnu_compiler_fix
mvertens 3d30938
updates for refactor of med_map_mod
e8b4214
added option for uv mapping with cart3d
dc41eab
cleanup of med_methods_mod
2268e9a
fixed bug for nems_orig
73ab226
merge to master resolved a space issue
14d8f11
Merge pull request #122 from ESCOMP/mvertens/perf
jedwards4b 7c22abe
backing out changes to med_io_mod.F90 should fix restart problem
8372158
Merge pull request #125 from ESCOMP/mvertens/fix_restart_bug
jedwards4b 771eacd
update med_io_mod.F90 for latest fix
DeniseWorthen 6770ed6
fixed the order of glc mapping and land merge - the calls were incorr…
fd5e23c
fixed bug in budget calculations
0315cae
Merge pull request #129 from ESCOMP/mvertens/fix_preplnd_bug
jedwards4b 2082024
first set of changes to have multiple ice sheets
1270896
successfully completed a TG run with just 1 ice sheets - results were…
ec373dc
cleaned up interface for addmrg to remove 1 index
c45fa55
fixed compilation issue
f5146b2
more updates and fixes for multiple ice sheets
ab8b4fd
fix preplnd bug
51562ca
Merge pull request #99 from danrosen25/fix/esmfversion
jedwards4b a3d7345
updates to get I2000 compset identical to the nov15 baseline
7de506d
cleanup merge issue
jedwards4b f1b6425
Merge pull request #135 from jedwards4b/remerge_esmf_versioning
jedwards4b 147e8a6
Merge pull request #134 from ESCOMP/mvertens/fixpreplnd
jedwards4b 3810a7a
Call GLC at the end of the day rather than the start
f04a4fd
pass areag for smb normalization
a9483bb
more fixes for glc renormalization
df8c749
Merge commit 'a9483bb' into mvertens/fixprepglc
2f1edfc
Merge pull request #138 from ESCOMP/mvertens/fixglc_runseq
billsacks ce1148b
cleanup and refactor of testlist_drv.xml to include new tests and con…
0345e83
updates to changes for mvertens/fixpreglc
9043f00
new wrapper interfaces for readability for getting pointers to field …
607c38e
Add a comment about the areas used in the global sums
billsacks 93b0da3
fix use statement
3eff0cb
Merge branch 'mvertens/fixprepglc' into mvertens/icesheets
34b67b6
udpates for PR #139
23896d4
bug fix
37bde42
replace mapconsf with mapconsd in prep_glc_mod.F90
8c1a42f
added med_phases_post_glc_mod.F90 which carries out the mapping for g…
b494a25
added med_phases_post_glc to run sequence
5c4e828
Merge pull request #139 from ESCOMP/mvertens/fixprepglc
mvertens 6452bec
bug fixes in testing
5bc6ffa
aded a post rof phase
8f54ebe
merge to mvertens/icesheets
3786519
clarified comments
f520ad9
fix avgdt variable and add nthreads value to gcomp
jedwards4b e045da7
major performance update for I2000 compset
492569c
Merge pull request #140 from ESCOMP/mvertens/icesheets
mvertens 59ec4d1
reworked how scalar data was set in med_phases_prep_lnd
bfd5ca7
more performance improvements
4589a19
fixed bug introduced in prep_ocn_mod with skipping wave mapping and a…
a722479
updates for mapping glc->ocn
bcd340c
Merge remote-tracking branch 'jedwards/fix_avgdt_add_nthreads_to_gcom…
de28293
removal of nems configuration - since nems driver is used in the future
7417a5a
fixed compile and restart problem for B compsets
f3e4d3a
Merge commit '7417a5a' into mvertens/postphases
7868fba
added post phases for ocn and atm
386e300
added med_phases_post_lnd
9ea5b94
added post wave phase
c310ff3
added post ice phase and fixed call to post atm phase
f2edb0f
more cleanup of post run phases
435bb52
unified merge and accum ocn phase and renamed ocn phases to be consis…
c570780
fixed problems encountered in PR testing
4a82768
update to pull request template
bb8214c
updated Makefile new post phase modules
94cde15
updated pr template to add HAFS
920bc97
updated module arrays to be initialized to null
ab8b90c
update med.F90 dependancies
jedwards4b 70b5aac
update cmake file
jedwards4b c6b58ce
corrected file name
3a05967
add post_ocn_mod
jedwards4b 0ccc872
Merge pull request #146 from ESCOMP/mvertens/postphases
jedwards4b 8746b78
changes needed to transfer ocean to glc coupling - now just from pop
7cb568e
bug fixes
ee7c824
Merge branch 'emc/develop' into feature/updcmeps
DeniseWorthen 69f714e
Merge remote-tracking branch 'escomp/master' into feature/updcmeps
DeniseWorthen 9c8b94f
fix error when scalar_id is 0 (triggered in new datm debug test)
DeniseWorthen 5e99e91
removed nems reference in buildnml
0e35a1b
bug fixes for ocn2glc coupling
0bdc342
fixed phrasing
aac5004
more phrasing fixes
b3b5995
Merge remote-tracking branch 'escomp/mvertens/ocn2glc_coupling' into …
DeniseWorthen 56a5e44
fix mismatched subname/subroutines
DeniseWorthen c5e9426
restore files
DeniseWorthen be36b4f
Merge pull request #148 from ESCOMP/mvertens/ocn2glc_coupling
mvertens 5754fac
Merge remote-tracking branch 'escomp/master' into feature/updcmeps
DeniseWorthen 493e283
update med_io_mod for version currently in cmeps/master
DeniseWorthen 1f67571
alternate fix for scalar_id=0 case
DeniseWorthen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
cmake_minimum_required(VERSION 3.10) | ||
include(ExternalProject) | ||
|
||
if (DEFINED CIMEROOT) | ||
message("Using CIME in ${CIMEROOT} with compiler ${COMPILER}") | ||
include(${CASEROOT}/Macros.cmake) | ||
if (${PIO_VERSION} LESS 2) | ||
message( FATAL_ERROR "Version 2 of the PIO library required") | ||
endif() | ||
if (${MPILIB} STREQUAL "mpi-serial") | ||
set(CMAKE_C_COMPILER ${SCC}) | ||
set(CMAKE_Fortran_COMPILER ${SFC}) | ||
set(CMAKE_CXX_COMPILER ${SCXX}) | ||
else() | ||
set(CMAKE_C_COMPILER ${MPICC}) | ||
set(CMAKE_Fortran_COMPILER ${MPIFC}) | ||
set(CMAKE_CXX_COMPILER ${MPICXX}) | ||
endif() | ||
set(CMAKE_Fortran_FLAGS "${FFLAGS} -I${LIBROOT}/include -I${LIBROOT}/finclude -I${LIBROOT}/nuopc/esmf/${NINST_VALUE}/include") | ||
else() | ||
set(BLD_STANDALONE TRUE) | ||
endif() | ||
|
||
project(CMEPS LANGUAGES Fortran VERSION 0.1) | ||
|
||
list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake) | ||
|
||
message("CMAKE_MODULE_PATH is ${CMAKE_MODULE_PATH}") | ||
|
||
find_package(ESMF REQUIRED) | ||
if (DEFINED PIO) | ||
set(PIO_PATH ${PIO}) | ||
else() | ||
set(PIO_PATH $ENV{PIO}) | ||
endif() | ||
find_package(PIO REQUIRED COMPONENT C Fortran PATH ${PIO_PATH}) | ||
|
||
if (NOT DEFINED MPILIB OR NOT ${MPILIB} STREQUAL "mpi-serial") | ||
find_package(MPI REQUIRED) | ||
endif() | ||
|
||
if(BLD_STANDALONE) | ||
add_subdirectory(nems/util) | ||
list(APPEND EXTRA_LIBS cmeps_share) | ||
list(APPEND EXTRA_INCLUDES "${CMAKE_BINARY_DIR}/nems/util") | ||
endif() | ||
|
||
add_subdirectory(mediator) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change UFS-s2s to UFS coupled testing in the future since the UFS tests covers both weather and s2s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll make a note; she said she has an upcoming PR also so she could do it then.