feat(module:calendar): custom header #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8418 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.02%
==========================================
Files 519 519
Lines 18076 18074 -2
Branches 2848 2761 -87
==========================================
- Hits 16561 16557 -4
- Misses 1216 1218 +2
Partials 299 299 ☔ View full report in Codecov by Sentry. |
|
|
||
| @if (mode === 'month') { | ||
| @if (nzCustomHeader) { | ||
| <ng-container [ngTemplateOutlet]="nzCustomHeader"></ng-container> |
There was a problem hiding this comment.
Use nzStringTemplateOutlet instead of ngTemplateOutlet, which allows nzCustomHeader to accept both strings and TemplateRef types.
Comment on lines
261
to
269
| <nz-calendar-header | ||
| [nzCustomHeader]="customHeader" | ||
| (yearChange)="year = $event" | ||
| (monthChange)="month = $event" | ||
| ></nz-calendar-header> | ||
|
|
||
| <ng-template #custom> | ||
| <p>custom</p> | ||
| </ng-template> |
There was a problem hiding this comment.
Suggested change
| <nz-calendar-header | |
| [nzCustomHeader]="customHeader" | |
| (yearChange)="year = $event" | |
| (monthChange)="month = $event" | |
| ></nz-calendar-header> | |
| <ng-template #custom> | |
| <p>custom</p> | |
| </ng-template> | |
| <nz-calendar-header | |
| [nzCustomHeader]="customHeader" | |
| (yearChange)="year = $event" | |
| (monthChange)="month = $event" | |
| ></nz-calendar-header> | |
| <ng-template #customHeader> | |
| <p>custom</p> | |
| </ng-template> |
HyperLife1119
added
PR: reviewed-changes-requested
PR: target-minor
and removed
PR: unreviewed
PR: target-major
labels
|
@HyperLife1119 |
HyperLife1119
added
PR: reviewed-approved
and removed
PR: reviewed-changes-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Custom Header feature for the Calendar component has been added.
What is the new behavior?
described above.
Does this PR introduce a breaking change?
Other information