-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:core): make no-animation standalone #8257
feat(module:core): make no-animation standalone #8257
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8257 +/- ##
==========================================
+ Coverage 91.70% 91.71% +0.01%
==========================================
Files 520 520
Lines 17898 17898
Branches 2750 2750
==========================================
+ Hits 16414 16416 +2
+ Misses 1181 1180 -1
+ Partials 303 302 -1 ☔ View full report in Codecov by Sentry. |
@HyperLife1119 does it looks good to you ? |
bc26415
to
372bc44
Compare
I need to wait for other components to complete the standalone transformation before I come back to check this. Because too many changes have occurred in the meantime. |
That’s made totally sens. I will rebase the other pr on implémentation new code flow on doc snippet and merge it, if you’re ok. Need this or to continue my work on the other components |
This PR is related to #8265. |
Can you resolve the conflict :) done |
Of course. Will do it during the day |
372bc44
to
ae2da48
Compare
6fb2d2c
to
1e66e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
NzNoAnimation Directive is not standalone
Issue Number: N/A
What is the new behavior?
NzNoAnimation Directive is standalone and NzNoAnimationModule is replaced in component library
Does this PR introduce a breaking change?
Other information