Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:core): make no-animation standalone #8257

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Dec 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

NzNoAnimation Directive is not standalone

Issue Number: N/A

What is the new behavior?

NzNoAnimation Directive is standalone and NzNoAnimationModule is replaced in component library

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

zorro-bot bot commented Dec 1, 2023

This preview will be available after the AzureCI is passed.

@Nicoss54 Nicoss54 self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5765ae9) 91.70% compared to head (1e66e48) 91.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8257      +/-   ##
==========================================
+ Coverage   91.70%   91.71%   +0.01%     
==========================================
  Files         520      520              
  Lines       17898    17898              
  Branches     2750     2750              
==========================================
+ Hits        16414    16416       +2     
+ Misses       1181     1180       -1     
+ Partials      303      302       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicoss54
Copy link
Collaborator Author

Nicoss54 commented Dec 2, 2023

@HyperLife1119 does it looks good to you ?

@Nicoss54 Nicoss54 force-pushed the feature/no-animation-standalone branch from bc26415 to 372bc44 Compare December 2, 2023 11:48
@HyperLife1119
Copy link
Collaborator

I need to wait for other components to complete the standalone transformation before I come back to check this. Because too many changes have occurred in the meantime.

@Nicoss54
Copy link
Collaborator Author

Nicoss54 commented Dec 4, 2023

I need to wait for other components to complete the standalone transformation before I come back to check this. Because too many changes have occurred in the meantime.

That’s made totally sens. I will rebase the other pr on implémentation new code flow on doc snippet and merge it, if you’re ok. Need this or to continue my work on the other components

@HyperLife1119
Copy link
Collaborator

This PR is related to #8265.

@HyperLife1119
Copy link
Collaborator

HyperLife1119 commented Dec 7, 2023

Can you resolve the conflict :)

done

@Nicoss54
Copy link
Collaborator Author

Nicoss54 commented Dec 7, 2023

Can you resolve the conflict :)

Of course. Will do it during the day

@Nicoss54 Nicoss54 force-pushed the feature/no-animation-standalone branch from 372bc44 to ae2da48 Compare December 7, 2023 09:43
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54 Nicoss54 merged commit de579bc into NG-ZORRO:master Dec 11, 2023
9 checks passed
@Nicoss54 Nicoss54 deleted the feature/no-animation-standalone branch December 11, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants