Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): nzAutoClearSearchValue is not work for select #8167

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

Nicoss54
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

This PR introduce a fix on how works the nzAutoClearSearchValue params.
When user click outside or use escape button the search value is clear in all case.

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When user click outside of the selectbox or press the keycap escape the search value is always clear even if the option nzAutoClearSearchValue is false

Issue Number: 8102

What is the new behavior?

Now if the user click outside or press the keycap escape, the search value is not clear if the option nzAutoClearSearchValue is set to false.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

zorro-bot bot commented Nov 17, 2023

This preview will be available after the AzureCI is passed.

@Nicoss54
Copy link
Collaborator Author

@OriginRing @simplejason , all test passed but unfortunatly there is a problem with CodeCov when uploading the result file of the test. I don't have enought rights to investigate more :/

@Nicoss54 Nicoss54 linked an issue Nov 17, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e37eab2) 91.72% compared to head (a9316a0) 91.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8167      +/-   ##
==========================================
- Coverage   91.72%   91.70%   -0.02%     
==========================================
  Files         519      519              
  Lines       17887    17888       +1     
  Branches     2836     2837       +1     
==========================================
- Hits        16406    16405       -1     
- Misses       1180     1181       +1     
- Partials      301      302       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicoss54
Copy link
Collaborator Author

@OriginRing @simplejason , all test passed but unfortunatly there is a problem with CodeCov when uploading the result file of the test. I don't have enought rights to investigate more :/

rerun the pipeline fix the issue, also see that the package we coecov is depcreted, do you think it's a good idea to migrate to the new uploader ?

@simplejason simplejason changed the title fix/nz-autoclear fix(module:select): nzAutoClearSearchValue is not work for select Nov 18, 2023
@Nicoss54 Nicoss54 merged commit fefcb68 into NG-ZORRO:master Nov 30, 2023
8 of 9 checks passed
@Nicoss54 Nicoss54 deleted the fix/nz-autoclear branch November 30, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzAutoClearSearchValue is not work for select
2 participants