fix(module:cascader,select,time-picker,tooltip,tree-select): take in account shadow dom when getting the target of an event #7853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If you have an ant component inside a ShadowDOM the function
onClickOutside
won't behave correctly.I did a small stackblitz to showcase the issue.
You have 2 selects: One inside a ShadowDOM, and one without ShadowDOM.
If you spam click the select in the ShadowDOM version you will see that the list will appear twice, which is not the case with the one not using the ShadowDOM.
The issue is due to how event propagation is done with ShadowDOM.
Concretely, the function
onClickOutside
will receive as a target the ShadowRoot, and not the real clicked element.To fix the issue you should take into account the ShadowDOM. Fortunately
@angular/cdk/platform
provides a function that does it which is_getEventTarget
.As a side note, here you have a great article that explain event propagation and shadow dom:
https://pm.dartus.fr/blog/a-complete-guide-on-shadow-dom-and-event-propagation/
What is the new behavior?
The behaviour will be exactly the same as today, however you won't have anymore a glitch when using your component inside a ShadowDOM.
Does this PR introduce a breaking change?
Other information
I am not sure how to test this.