Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): usage public property in accessing other components #679

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Dec 5, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: CI is down due to merge conflict.

What is the new behavior?

Fix the CI.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 20c4725 on trotyl:hot-fix into ** on NG-ZORRO:master**.

@vthinkxie vthinkxie merged commit 8ba3ea8 into NG-ZORRO:master Dec 5, 2017
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Dec 6, 2017
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants