Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:rate): support customize character #6787

Merged

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

https://ant.design/components/rate-cn/#components-rate-demo-character-function

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #6787 (907d5d3) into master (1ec3f64) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6787      +/-   ##
==========================================
- Coverage   89.88%   89.58%   -0.31%     
==========================================
  Files         479      488       +9     
  Lines       15489    15779     +290     
  Branches     2522     2423      -99     
==========================================
+ Hits        13923    14135     +212     
- Misses        943     1004      +61     
- Partials      623      640      +17     
Impacted Files Coverage Δ
components/rate/rate-item.component.ts 88.88% <ø> (+1.38%) ⬆️
components/rate/rate.component.ts 96.03% <ø> (ø)
components/core/config/config.service.ts 91.17% <0.00%> (-5.89%) ⬇️
components/steps/steps.component.ts 91.13% <0.00%> (-5.79%) ⬇️
components/popconfirm/popconfirm.ts 96.00% <0.00%> (-4.00%) ⬇️
...onents/table/src/addon/filter-trigger.component.ts 40.90% <0.00%> (-2.57%) ⬇️
components/steps/step.component.ts 95.91% <0.00%> (-1.81%) ⬇️
components/select/select.component.ts 87.22% <0.00%> (-0.05%) ⬇️
components/empty/config.ts 100.00% <0.00%> (ø)
components/message/base.ts 87.70% <0.00%> (ø)
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec3f64...907d5d3. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants