-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:slider): fix range slider not working for arrow keys #6612
fix(module:slider): fix range slider not working for arrow keys #6612
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #6612 +/- ##
==========================================
- Coverage 89.90% 89.88% -0.03%
==========================================
Files 481 481
Lines 15379 15388 +9
Branches 2344 2348 +4
==========================================
+ Hits 13827 13831 +4
- Misses 935 938 +3
- Partials 617 619 +2
Continue to review full report at Codecov.
|
897716e
to
d77b026
Compare
@wendellhu95 Please review this. |
@@ -103,6 +103,7 @@ import { NzExtendedMark, NzMarks, NzSliderHandler, NzSliderShowTooltip, NzSlider | |||
[tooltipVisible]="nzTooltipVisible" | |||
[tooltipPlacement]="nzTooltipPlacement" | |||
[dir]="dir" | |||
(keydown)="onHandleKeyDown(handleIndex)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(keydown)="onHandleKeyDown(handleIndex)" | |
(focusin)="onHandleKeyDown(handleIndex)" |
Is it possible to use focusin here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, pls review it again~
d77b026
to
4b1e4c1
Compare
4b1e4c1
to
75c38f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
close #6586
What is the new behavior?
Does this PR introduce a breaking change?
Other information