Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:slider): fix range slider not working for arrow keys #6612

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

close #6586

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 18, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #6612 (7bda9f9) into master (48a9714) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

❗ Current head 7bda9f9 differs from pull request most recent head 75c38f3. Consider uploading reports for the commit 75c38f3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6612      +/-   ##
==========================================
- Coverage   89.90%   89.88%   -0.03%     
==========================================
  Files         481      481              
  Lines       15379    15388       +9     
  Branches     2344     2348       +4     
==========================================
+ Hits        13827    13831       +4     
- Misses        935      938       +3     
- Partials      617      619       +2     
Impacted Files Coverage Δ
components/image/image-config.ts 100.00% <ø> (ø)
components/modal/modal-config.ts 100.00% <ø> (ø)
components/slider/slider.component.ts 90.40% <60.00%> (-0.54%) ⬇️
components/core/time/candy-date.ts 86.75% <100.00%> (+0.17%) ⬆️
components/date-picker/date-picker.component.ts 93.37% <100.00%> (ø)
components/date-picker/date-picker.service.ts 100.00% <100.00%> (ø)
...mponents/date-picker/date-range-popup.component.ts 90.42% <100.00%> (+0.64%) ⬆️
components/date-picker/picker.component.ts 91.76% <100.00%> (ø)
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a9714...75c38f3. Read the comment docs.

@wenqi73
Copy link
Member

wenqi73 commented Apr 20, 2021

@wendellhu95 Please review this.

@@ -103,6 +103,7 @@ import { NzExtendedMark, NzMarks, NzSliderHandler, NzSliderShowTooltip, NzSlider
[tooltipVisible]="nzTooltipVisible"
[tooltipPlacement]="nzTooltipPlacement"
[dir]="dir"
(keydown)="onHandleKeyDown(handleIndex)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(keydown)="onHandleKeyDown(handleIndex)"
(focusin)="onHandleKeyDown(handleIndex)"

Is it possible to use focusin here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, pls review it again~

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@hsuanxyz hsuanxyz merged commit 51f33e6 into NG-ZORRO:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using range slider with arrow keys doesn't work
4 participants