Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:mention): preserve white spaces when insert suggestions #6505

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

hsuanxyz
Copy link
Member

fix #6175

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 11, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #6505 (440a38b) into master (85ea273) will increase coverage by 0.03%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6505      +/-   ##
==========================================
+ Coverage   89.82%   89.86%   +0.03%     
==========================================
  Files         478      480       +2     
  Lines       15314    15325      +11     
  Branches     2475     2334     -141     
==========================================
+ Hits        13756    13772      +16     
+ Misses        940      935       -5     
  Partials      618      618              
Impacted Files Coverage Δ
components/pagination/pagination-item.component.ts 100.00% <ø> (ø)
components/rate/rate.component.ts 96.03% <ø> (ø)
components/space/space.module.ts 100.00% <ø> (ø)
components/mention/mention.component.ts 97.72% <75.00%> (+0.01%) ⬆️
components/mention/config.ts 100.00% <100.00%> (ø)
components/mention/mention-trigger.ts 100.00% <100.00%> (ø)
components/space/space-item.component.ts 100.00% <100.00%> (ø)
components/space/space-item.directive.ts 100.00% <100.00%> (ø)
components/space/space.component.ts 100.00% <100.00%> (ø)
components/tooltip/base.ts 91.98% <100.00%> (+0.94%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ea273...c91567e. Read the comment docs.

@hsuanxyz hsuanxyz merged commit d5ed97e into NG-ZORRO:master Mar 22, 2021
@hsuanxyz hsuanxyz deleted the fix/mention-insert-space branch March 22, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-mention can not fill the input correctly with a option that contain a blank as prefix
1 participant