Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tooltip): keep tooltip visibility when trigger is null #6489

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

close #6483
close #6402

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 6, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #6489 (19275ac) into master (0e326e7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6489   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         478      478           
  Lines       15314    15314           
  Branches     2332     2332           
=======================================
  Hits        13758    13758           
+ Misses        939      938    -1     
- Partials      617      618    +1     
Impacted Files Coverage Δ
components/tooltip/base.ts 91.98% <100.00%> (+0.94%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e326e7...0c158aa. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vthinkxie vthinkxie merged commit 0de0e6f into NG-ZORRO:master Mar 8, 2021
@Aizaz-Ulhaq
Copy link

Aizaz-Ulhaq commented Mar 8, 2021

The issue is still there. It's not solved (as of documentation page). please look at the attached .gif from the documentation page. Clicking anywhere on the page or on the scroller still hides the tooltip.
captured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants