Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:time-picker,select,tree-select): support nzId #6379

Merged
merged 3 commits into from
Feb 26, 2021
Merged

feat(module:time-picker,select,tree-select): support nzId #6379

merged 3 commits into from
Feb 26, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 25, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 25, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #6379 (0040097) into master (4d80873) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6379      +/-   ##
==========================================
+ Coverage   89.83%   89.84%   +0.01%     
==========================================
  Files         478      478              
  Lines       15314    15319       +5     
  Branches     2475     2475              
==========================================
+ Hits        13757    13764       +7     
+ Misses        940      939       -1     
+ Partials      617      616       -1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 93.42% <ø> (ø)
components/date-picker/picker.component.ts 89.88% <100.00%> (ø)
components/select/select-search.component.ts 87.50% <100.00%> (+0.26%) ⬆️
components/select/select-top-control.component.ts 89.53% <100.00%> (+0.12%) ⬆️
components/select/select.component.ts 87.90% <100.00%> (+0.03%) ⬆️
components/time-picker/time-picker.component.ts 86.20% <100.00%> (+0.09%) ⬆️
components/tree-select/tree-select.component.ts 89.31% <100.00%> (+0.04%) ⬆️
components/tabs/tab-nav-bar.component.ts 83.09% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d80873...920f7ae. Read the comment docs.

cipchk added a commit to ng-alain/delon that referenced this pull request Jan 25, 2021
@hsuanxyz
Copy link
Member

@cipchk 代码冲突了

@cipchk
Copy link
Member Author

cipchk commented Feb 25, 2021

@cipchk 代码冲突了

已处理。

@hsuanxyz hsuanxyz merged commit 85d423d into NG-ZORRO:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants