Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:slider): change mark style in horizontal mode #3879

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 29, 2019

close #3876

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3876

What is the new behavior?

Use transform instead of width and marginLeft.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 29, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 665c215

https://deploy-preview-3879--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #3879 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3879      +/-   ##
==========================================
+ Coverage   95.23%   95.24%   +<.01%     
==========================================
  Files         726      726              
  Lines       14668    14665       -3     
  Branches     1910     1910              
==========================================
- Hits        13969    13967       -2     
  Misses        260      260              
+ Partials      439      438       -1
Impacted Files Coverage Δ
components/slider/nz-slider-marks.component.ts 89.74% <100%> (-0.74%) ⬇️
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42c788...665c215. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit e6a6221 into NG-ZORRO:master Jul 29, 2019
@wzhudev wzhudev deleted the slider-mark-width branch August 2, 2019 02:15
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: "ant-slider-mark-text" have unexpected width.
2 participants