Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): support pressing ESC to close drawer #3488

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: ant-design/ant-design#16694

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented May 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5adf062

https://deploy-preview-3488--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #3488 into master will increase coverage by 0.08%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
+ Coverage    95.6%   95.69%   +0.08%     
==========================================
  Files         609      682      +73     
  Lines       13250    13572     +322     
  Branches     1810     1811       +1     
==========================================
+ Hits        12668    12988     +320     
- Misses        197      198       +1     
- Partials      385      386       +1
Impacted Files Coverage Δ
components/drawer/nz-drawer.component.ts 96.51% <93.33%> (-0.48%) ⬇️
components/anchor/index.ts 100% <0%> (ø)
components/rate/index.ts 100% <0%> (ø)
components/ng-zorro-antd.module.ts 99.2% <0%> (ø)
components/upload/public-api.ts 100% <0%> (ø)
components/back-top/public-api.ts 100% <0%> (ø)
components/layout/public-api.ts 100% <0%> (ø)
components/table/public-api.ts 100% <0%> (ø)
components/upload/index.ts 100% <0%> (ø)
components/badge/index.ts 100% <0%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6342657...5adf062. Read the comment docs.

@simplejason simplejason merged commit 2928f84 into NG-ZORRO:master Jun 5, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the feta/drawer-esc branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants