Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:carousel): fix carousel in entry components #3367

Merged
merged 3 commits into from
May 17, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 25, 2019

close #3337

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Apr 25, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6450f25

https://deploy-preview-3367--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #3367 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3367      +/-   ##
==========================================
+ Coverage   97.44%   97.44%   +<.01%     
==========================================
  Files         609      609              
  Lines       11947    11951       +4     
  Branches      871      871              
==========================================
+ Hits        11642    11646       +4     
  Misses        196      196              
  Partials      109      109
Impacted Files Coverage Δ
components/carousel/nz-carousel.component.ts 97.18% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f353c...6450f25. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 9d495fc into NG-ZORRO:master May 17, 2019
@wzhudev wzhudev deleted the carousel-initial-render branch June 18, 2019 07:11
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:carousel): fix carousel in entry components

* fix: test

* fix: typo
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:carousel): fix carousel in entry components

* fix: test

* fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

走马灯放到Modal对话框和Popover气泡卡片里面显示问题
2 participants