-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:modal): support use directive to define the footer #3036
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 0929087 |
Codecov Report
@@ Coverage Diff @@
## master #3036 +/- ##
==========================================
- Coverage 95.39% 95.38% -0.01%
==========================================
Files 712 700 -12
Lines 14633 14506 -127
Branches 1929 1915 -14
==========================================
- Hits 13959 13837 -122
+ Misses 244 243 -1
+ Partials 430 426 -4
Continue to review full report at Codecov.
|
de2644b
to
982473b
Compare
ff62600
to
c185239
Compare
b535ad4
to
6e7524d
Compare
6e7524d
to
cff77c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…RRO#3036) * feat(module:modal): support use directive to define the footer close NG-ZORRO#3035 * docs(module:modal): add custom footer demo * test(module:modal): add test * test(module:modal): add test * fix(module:modal): fix type * test(module:modal): fix test * chore: rebase master * chore: rebase master * test(module:modal): fix test * test(module:modal): fix test
…RRO#3036) * feat(module:modal): support use directive to define the footer close NG-ZORRO#3035 * docs(module:modal): add custom footer demo * test(module:modal): add test * test(module:modal): add test * fix(module:modal): fix type * test(module:modal): fix test * chore: rebase master * chore: rebase master * test(module:modal): fix test * test(module:modal): fix test
close #3035
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information