feat(module:calendar): sync some changes from ant-design (#2769) #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 535d595 |
Codecov Report
@@ Coverage Diff @@
## master #2963 +/- ##
==========================================
+ Coverage 97.37% 97.38% +0.01%
==========================================
Files 545 545
Lines 11260 11266 +6
Branches 809 809
==========================================
+ Hits 10964 10971 +7
+ Misses 188 187 -1
Partials 108 108
Continue to review full report at Codecov.
|
zhytang
force-pushed
the
add-zhytang
branch
2 times, most recently
from
9c1f206
to
b681cba
Compare
vthinkxie
requested changes
Feb 25, 2019
vthinkxie
reviewed
Feb 26, 2019
| this.nzModeChange.emit(mode); | ||
| this.nzPanelChange.emit({'date': this.activeDate, 'mode': mode}); |
There was a problem hiding this comment.
组合 nzModeChange 和 nzValueChange 就可以得到 nzPanelChange 的内容，为什么还要再增加 nzPanelChange 这个 output
There was a problem hiding this comment.
为了和ant-design同步，这个issue不是这个意思？
vthinkxie
reviewed
Feb 26, 2019
| } | ||
|
|
||
| onMonthSelect(month: number): void { | ||
| const date = setMonth(this.activeDate, month); | ||
| this.updateDate(date); | ||
| this.nzSelectChange.emit(date); |
There was a problem hiding this comment.
nzSelectChange 和 nzValueChange 的区别是什么
vthinkxie
approved these changes
Feb 26, 2019
Closed
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2769
What is the new behavior?
Does this PR introduce a breaking change?
Other information