Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: action='extend' in v0.2.0 breaks compatabilty with Python3 < 3.8 #18

Closed
1 task done
log1-c opened this issue Feb 12, 2024 · 5 comments
Closed
1 task done
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@log1-c
Copy link

log1-c commented Feb 12, 2024

Please try to fill out as much of the information below as you can. Thank you!

  • Yes, I've searched similar issues on GitHub and didn't find any.

Which version contains the bug?

0.2.0

Describe the bug

v0.2.0 introduced the exclude parameter which is defined with action='extend' in the code.
This renders the script unusable on systems having a Python3 version lower than 3.8, like RHEL8 for example.

How to recreate the bug?

Download and execute v0.2.0 of the script on a system with Python3 lower than 3.8

@log1-c log1-c added bug Something isn't working needs-triage Needs to be triaged labels Feb 12, 2024
@martialblog
Copy link
Member

Hi, while I wouldn't call this a "bug" I do understand that it is inconvenient.

Since earlier versions than Python 3.8 are end-of-life and Python 3.8 should be available in the RHEL8 repos right now, I feel a bit reluctant to change the current code.

However, shouldn't be to much of a change, so we could have version without action='extend' on a "backport" branch.

@log1-c Do you have code that is working for you?

@martialblog martialblog self-assigned this Feb 12, 2024
@martialblog martialblog removed the needs-triage Needs to be triaged label Feb 12, 2024
@log1-c
Copy link
Author

log1-c commented Feb 12, 2024

Thanks for the quick reply.
Wasn't shure if I should open it as a "bug" or more a "documentation",as I mostly meant it as an FYI. And I can understand if you are not willing to change the code!

I have switched back to a earlier version, as we currently don't use the exclude parameter.
Will also discuss internally if raising the Python3 version is an option.

@martialblog
Copy link
Member

I'll update the README accordingly

This should work on older versions, I tested it on Python 3.6: https://github.com/NETWAYS/check_vmware_nsxt/tree/backport

@martialblog martialblog added documentation Improvements or additions to documentation and removed bug Something isn't working labels Feb 12, 2024
@martialblog
Copy link
Member

README is updated on both branches.

@log1-c can you confirm the code is working?

@log1-c
Copy link
Author

log1-c commented Feb 12, 2024

yes, script from https://github.com/NETWAYS/check_vmware_nsxt/tree/backport works.
thank you!

@log1-c log1-c closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants