Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an alias for temporal_torus_translation #65

Closed
aammd opened this issue Feb 26, 2016 · 1 comment
Closed

add an alias for temporal_torus_translation #65

aammd opened this issue Feb 26, 2016 · 1 comment
Assignees
Milestone

Comments

@aammd
Copy link
Collaborator

aammd commented Feb 26, 2016

reviewer comment:

Alternative names for these permutations are "caterpillar randomization" and "cyclic shift permutation". The latter is the much more common terminology applied to these cyclic permutations.

A pity, because "caterpillar randomization" is rather charming 🐛 🕙 🐛

The suggested fix is to simply add an alias (e.g. cyclic_shift()) to replace temporal_torus_translation()

@laurenmh laurenmh self-assigned this Mar 4, 2016
@aammd
Copy link
Collaborator Author

aammd commented Mar 23, 2016

Are we going to use an alias for this? I believe it was suggested to avoid breaking any existing code that used temporal_torus_translation() -- but it looks like we've just decided to change the name to cyclic_shift() everywhere. I think that's fine! I suggest we close this one.
speaking of which, are we going to rename the .R file cyclic_shift.R or keep the old name?

@mbjones mbjones modified the milestone: 1.1.0 Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants