Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CI #119

Closed
dcherian opened this issue Jan 13, 2022 · 2 comments · Fixed by #120
Closed

fix CI #119

dcherian opened this issue Jan 13, 2022 · 2 comments · Fixed by #120

Comments

@dcherian
Copy link
Contributor

CircleCI is failing and it's not clear to me what it's checking given that we have Github Actions and RTD builds running.

I think we can also delete the linting workflow now that pre-commit.ci is activated.

@andersy005 does this sound right to you?
@andersy005 andersy005 mentioned this issue Jan 13, 2022
Merged
@andersy005
Copy link
Contributor

CircleCI is failing and it's not clear to me what it's checking given that we have Github Actions and RTD builds running.

The CircleCI issue should be fixed now (it was due to an old webhook that didn't get uninstalled when we disable CircleCI)

I think we can also delete the linting workflow now that pre-commit.ci is activated.

#120 fixes this.

@dcherian
Copy link
Contributor Author

Wonderful. Thanks Anderson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove linting workflow in favor of pre-commit.ci NCAR/pop-tools
2 participants
@dcherian @andersy005