Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create species map from the chemical species common to both WACCM and MUSICA species.json TS1 #228

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

carl-drews
Copy link
Collaborator

There are 75 chemical species currently mapped.
The python code has more diagnistics than we need for production, but in these early stages I find the extra info useful.
Logger gives warnings and the list of species not mapped, because chemical is present in only one list.

Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a couple minor questions but nothing preventing a merge

src/acom_music_box/tools/waccmToMusicBox.py Show resolved Hide resolved
src/acom_music_box/tools/waccmToMusicBox.py Show resolved Hide resolved
src/acom_music_box/tools/waccmToMusicBox.py Show resolved Hide resolved
@carl-drews
Copy link
Collaborator Author

I think @K20shores wanted to get the species map by sundown, so he can go ahead and merge this PR.

@K20shores K20shores merged commit 4e26af4 into main Sep 5, 2024
4 checks passed
@K20shores K20shores deleted the species-map branch September 5, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants