Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for demo #207

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Bug fixes for demo #207

merged 6 commits into from
Aug 28, 2024

Conversation

mattldawson
Copy link
Collaborator

@mattldawson mattldawson commented Aug 27, 2024 •
edited
Loading

  • Fixes a bug that prevented the last set of evolving conditions from being included in the solve
  • Allows user-defined reactions in mechanisms
  • Adjust time solver time step to land exactly on updates to evolving conditions and output times

closes #166

@mattldawson mattldawson marked this pull request as ready for review August 28, 2024 01:19
@K20shores K20shores merged commit 4f02e3e into main Aug 28, 2024
4 checks passed
@K20shores K20shores deleted the debug-music-box branch August 28, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K20shores K20shores K20shores approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure evolving conditions are working properly
2 participants
@mattldawson @K20shores