fix timestepping

NCAR · Aug 28, 2024 · 69e0dd2 · 69e0dd2
1 parent 4ec7aef
commit 69e0dd2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/acom_music_box/music_box.py b/src/acom_music_box/music_box.py
@@ -543,12 +543,10 @@ def solve(self, output_path=None):
             # ensure the time step is not greater than the next update to the
             # evolving conditions or the next output time
             time_step = self.box_model_options.chem_step_time
-            if (next_conditions is not None and next_conditions_time > (curr_time + self.box_model_options.chem_step_time)):
-                time_step = min(time_step,
-                                next_conditions_time - (curr_time + self.box_model_options.chem_step_time))
-            if (next_output_time > (curr_time + self.box_model_options.chem_step_time)):
-                time_step = min(time_step,
-                                next_output_time - (curr_time + self.box_model_options.chem_step_time))
+            if (next_conditions is not None and next_conditions_time > curr_time):
+                time_step = min(time_step, next_conditions_time - curr_time)
+            if (next_output_time > curr_time):
+                time_step = min(time_step, next_output_time - curr_time)
 
             # solves and updates concentration values in concentration array
             if (not ordered_concentrations):

diff --git a/tests/test_chapman.py b/tests/test_chapman.py
@@ -58,7 +58,7 @@ def test_run(self):
                 assert math.isclose(
                     float(model_output_concs[i][j]),
                     float(test_output_concs[i][j]),
-                    rel_tol=1e-8,
+                    rel_tol=1e-7,
                     abs_tol=1e-15,
                 ), f"Arrays differ at index ({i}, {j}) for species {concs_to_test[j]}"