More fixes again #431
Merged
More fixes again #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will pull down this branch and run it with my command-line music_box.py. |
|
Carl Drews 9:05 AM |
carl-drews
approved these changes
Aug 27, 2024
|
@carl-drews that's easily changed in the UI. We can show them how in the demo tomorrow as a short little exercise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes concentrations, environmental conditions form the configuration files. The concentrations are placed into my_config.js. I also made sure any error from music box gets sent back to the UI. This creates something that runs TS1, but we have much to do to fix the initial conditions
I think this closes #420