Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dtc develop from ncar master 2020/06/06 #52

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 7, 2020

Changes in this PR:

  • selected updates from public release
  • code cleanup
  • use separate array for ice subsurface temperature
  • merge GFS and HWRF saSAS
  • butterfly effect
  • cellular automata
  • etc

Associated PRs:

NCAR/ccpp-framework#301
NCAR/ccpp-physics#458
NCAR/GFDL_atmos_cubed_sphere#12
#52
NCAR/ufs-weather-model#50

For regression testing information, see NCAR/ufs-weather-model#50.

climbfuji and others added 13 commits April 17, 2020 09:29
* Update .gitmodules and submodule pointers for GFDL_atmos_cubed_sphere, ccpp-framework, ccpp-physics for code review and testing

* Merge NCAR:dtc/develop into NOAA-EMC:develop

- RRTMGP in CCPP
- build system improvement: get CCPP kind and type definitions from CCPP framework, remove libxml2 from static CCPP build
- cleanup radiation tendencies in CCPP
- required cmake version now 3.0
- missing code changes for MG-IN-CCN update (from code review)
* Porting to Orion
* Remove old comments/code related to arguments mismatch (ifdef __GFORTRAN__)
* Remove CCPP dynamic build from framework
* Bug fix in ccpp/driver/CCPP_driver.F90
…owup bugfix (NOAA-EMC#104)

* point to ccpp branch chsp_latlon_post

* add chsp code changes from Jongil

Co-authored-by: Jongil Han <jingil.han@noaa.gov>

* add landsfcmdl variable to model sfc history file meta data

* add global latlon grid on write grid component, code changes from Jeffrey Whitaker

Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>

* add chsp code changes in ccpp-physics

Co-authored-by: Jongil Han <jongil.han@noaa.gov>

* remove support for legacy Intel compilers in CCPP gmake build

Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>

* update ccpp physics, fix syntax error

* update sflx.f in ccpp physics

* CCN-IN followup bugfix

Co-authored-by: Grant Firl <grantf@ucar.edu>

* Bugfix for GNU compiler in io/module_wrt_grid_comp.F90; bugfix in gfsphysics/physics/sfc_diff.f; updates for CCPP

* merge fv3 dycore ccpp framework and physics to the latest repoes

* cmeps integration changes

Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>

* update CCPP with tsfcl change

* fix timestr in module_cap_cpl.F90

* fix syntax error in ugwp_driver_v0.F

* point ccpp/physics back to NCAR master

Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com>
Co-authored-by: Jeffrey Whitaker <Jeffrey.S.Whitaker@noaa.gov>
Co-authored-by: Jongil Han <jongil.han@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@noaa.gov>
Co-authored-by: Grant Firl <grantf@ucar.edu>
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Co-authored-by: Denise Worthen <Denise.Worthen@noaa.gov>
Updates to cellular automata for deep convection. Some cleaning. Changes goes with updates in stochastic_physics and ccpp/physics repositories.
…c-v4 back to master (NOAA-EMC#113)

* Update CCPP version number from 3 to 4
* gfsphysics/GFS_layer/GFS_physics_driver.F90: update comment on location of code in CCPP
* Add no_nsst CCPP suites from public release
* Bugfixes for CCPP: check for and correct syntax of \htmlinclude lines
…s.F90, ... (NOAA-EMC#115)

* atmos_model.F90: bugfix for GNU compiler
* Update CCPP suite definition files suite_FV3_GFS_2017_gfdlmp_regional.xml and suite_FV3_GFS_2017_gfdlmp_regional_c768.xml
* gfsphysics/CCPP_layer/CCPP_typedefs.F90: set pointers to hydrometeors only if valid
* Remove non-existent include directory namphysics
(1) Introducing a separate array "tiice" to store internal ice temperature. "tiice" will be added to phyf*nc output only when frac_grid=T.
(2) When cplflx=T, initializing ice fluxes by PBL calculated values when fluxes from CICE are unavailable.
(3) Adding frac_grid to namelist and no longer modifying it inside FV3GFS_io.F90. frac_grid=F by default.
remove cheyenne.pgi from CCPP config (ccpp/set_compilers.sh, ccpp/build_ccpp.sh)
* Merge branch 'man_hafs_sas_without_updates_of_dtc_develop_49b73a8f4149ca88f071dbaae81f1769b120f1e0' into HEAD
* gfsphysics/physics/GFS_debug.F90: add capability to debug 1-d logical arrays
* Clean up error messages in gfsphysics/GFS_layer/GFS_typedefs.F90

Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
@climbfuji
Copy link
Collaborator Author

This PR contains changes coming from the authoritative repositories, which have been approved earlier by the codeowners. The code is identical to the authoritative repositories, except for few differences described in NCAR/ufs-weather-model#50, and all tests passed. I am therefore merging this PR without additional approval.

…tmos_cubed_sphere, ccpp-framework, ccpp-physics
@climbfuji climbfuji merged commit e7fe5fa into NCAR:dtc/develop Jun 8, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/fv3atm that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants