NoahMP: add #define CCPP to support removal of IPD #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move_ipd_step3_and_5
…move_ipd_step3_and_5
This was referenced Jan 8, 2021
…move_ipd_step3_and_5
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the removal process of IPD from the UFS and addresses steps 3 and 5 in NOAA-EMC/fv3atm#214.
Changes:
CMakeLists.txtto look for the CCPP cmake snippets in the correct location (the current code wouldn't work if fv3atm didn't do the same with the correct locations).#define CCPPto three NoahMP routines, because -DCCPP is no longer passed to the compiler. See issue Remove preprocessor directives looking for CCPP from Noah MP source code #543 for follow-up cleanup work.Associated PRs:
NOAA-EMC/GFDL_atmos_cubed_sphere#50
#547
NOAA-EMC/fv3atm#224
NOAA-EMC/NEMS#87
ufs-community/ufs-weather-model#357
For regression testing, see ufs-community/ufs-weather-model#357.