Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master from gmtb/develop 2019/10/16 #340

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 16, 2019

Associated PRs:

NCAR/ccpp-framework#230
#340
NOAA-EMC/GFDL_atmos_cubed_sphere#5
NOAA-EMC/fv3atm#1
ufs-community/ufs-weather-model#1
NOAA-EMC/NEMS#11 (merged)
NOAA-EMC/NEMS#12

See ufs-community/ufs-weather-model#1 for a description and regression testing information.

Changes specific to ccpp-physics:

  • GFS v16 updates from IPD, including bugfixes made for IPD physics as part of Update FV3atm/develop with changes from gmtb/develop as of 2019/10/16 NOAA-EMC/fv3atm#1
  • add Noah MP scheme
  • add logic to initialize certain fields if absent in the coldstart/restart files to GFS_phys_time_vary_run (first time step only); this is currently deactivated and the original code in FV3GFS_io.F90 is still used, because of precision mismatches when dynamics (including FV3GFS_io.F90!) are compiled in 32bit precision, while physics are compiled in 64bit precision
  • add GSD drag_suite scheme
  • add MYJ scheme
  • avoid passing GFS_control DDT to GFS_time_vary_pre_run, split up (this is a CCPP requirement for achieving portability that we are working towards)
  • update of CMakeLists.txt for out-of-source build/moving ccpp inside FV3 (replace relative paths ./ to source files with ${CMAKE_CURRENT_SOURCE_DIR}/)
  • bugfixes for existing GSD (RAP/HRRR) physics
  • rename physics/ugwp_driver_v0.f to physics/ugwp_driver_v0.F to enable preprocessing

grantfirl and others added 30 commits August 20, 2019 11:40
…y_pre_run; update GFS_time_vary_pre_run.fv3.F90 to new metadata and remove DDT dependency
… because it was originally done after the call to ccpp_physics_init in FV3GFS_io.F90/sfc_prop_restart_read
…use it was originally done after the call to ccpp_physics_init in FV3GFS_io.F90/sfc_prop_restart_read); this needs to happen before radition is called
….F90 that replaced legacy code (GOTO statements) with more complicated code
tanyasmirnova and others added 11 commits October 10, 2019 19:26
… microphysics, directly without recomputing it with taking into account temperature-based treatment of convective precipitation. This change will affect only use of RUC LSM with GFDL or Thompson microphysics.
Fraction of frozen precipitation with RUC LSM
…lab_master_20191006

Update gmtb/develop with GFSv16 changes from IPD 2019/10/06
…to merge_gsd_develop_drag_suite_update_and_bugfixes
Added semi-implicit time differencing for turbulent form drag and sma…
…nto merge_gsd_develop_drag_suite_update_and_bugfixes
…bles changes the results, this is only true in (CCPP) PROD mode, not in REPRO mode
…te_update_and_bugfixes

Merge gsd/develop, drag suite update and other bug fixes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the physics changes had already been approved into gmtb/develop, I only looked closely at CMakeLists.txt. Those changes look fine (and definitely help readability).

@climbfuji climbfuji merged commit d4b1cd0 into NCAR:master Oct 31, 2019
@climbfuji climbfuji deleted the update_master_from_gmtb_develop_20191016 branch June 27, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants