-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master from gmtb/develop 2019/10/16 #340
Merged
climbfuji
merged 83 commits into
NCAR:master
from
climbfuji:update_master_from_gmtb_develop_20191016
Oct 31, 2019
Merged
Update master from gmtb/develop 2019/10/16 #340
climbfuji
merged 83 commits into
NCAR:master
from
climbfuji:update_master_from_gmtb_develop_20191016
Oct 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or handling dates)
…y_pre_run; update GFS_time_vary_pre_run.fv3.F90 to new metadata and remove DDT dependency
… because it was originally done after the call to ccpp_physics_init in FV3GFS_io.F90/sfc_prop_restart_read
…use it was originally done after the call to ccpp_physics_init in FV3GFS_io.F90/sfc_prop_restart_read); this needs to happen before radition is called
…specific interstitial to test for b4b
….F90 that replaced legacy code (GOTO statements) with more complicated code
…rapper.F90 to new metadata format
…to myj_with_dom_mods
…j_with_dom_mods
… microphysics, directly without recomputing it with taking into account temperature-based treatment of convective precipitation. This change will affect only use of RUC LSM with GFDL or Thompson microphysics.
Fraction of frozen precipitation with RUC LSM
…lab_master_20191006 Update gmtb/develop with GFSv16 changes from IPD 2019/10/06
…may not be allocated
…to merge_gsd_develop_drag_suite_update_and_bugfixes
Added semi-implicit time differencing for turbulent form drag and sma…
…nto merge_gsd_develop_drag_suite_update_and_bugfixes
…bles changes the results, this is only true in (CCPP) PROD mode, not in REPRO mode
…te_update_and_bugfixes Merge gsd/develop, drag suite update and other bug fixes
This was referenced Oct 16, 2019
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
October 16, 2019 23:21
…m/climbfuji/ccpp-physics into update_master_from_gmtb_develop_20191016
…ps for creatig list of Fortran module files to install (static build only)
This was referenced Oct 22, 2019
grantfirl
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the physics changes had already been approved into gmtb/develop, I only looked closely at CMakeLists.txt. Those changes look fine (and definitely help readability).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PRs:
NCAR/ccpp-framework#230
#340
NOAA-EMC/GFDL_atmos_cubed_sphere#5
NOAA-EMC/fv3atm#1
ufs-community/ufs-weather-model#1
NOAA-EMC/NEMS#11 (merged)
NOAA-EMC/NEMS#12
See ufs-community/ufs-weather-model#1 for a description and regression testing information.
Changes specific to ccpp-physics:
GFS_phys_time_vary_run
(first time step only); this is currently deactivated and the original code inFV3GFS_io.F90
is still used, because of precision mismatches when dynamics (includingFV3GFS_io.F90
!) are compiled in 32bit precision, while physics are compiled in 64bit precisionGFS_control
DDT toGFS_time_vary_pre_run
, split up (this is a CCPP requirement for achieving portability that we are working towards)./
to source files with${CMAKE_CURRENT_SOURCE_DIR}/
)physics/ugwp_driver_v0.f
tophysics/ugwp_driver_v0.F
to enable preprocessing