Merge gsd/develop, drag suite update and other bug fixes #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to SCM version of GFS_time_vary_pre.F90
…tb_develop_20190924 Update gsd/develop from gmtb/develop 2019/09/24
… be used in the check for consistency of land information.
Added sea_land_ice_mask to sfc_drv_ruc.F90
… microphysics, directly without recomputing it with taking into account temperature-based treatment of convective precipitation. This change will affect only use of RUC LSM with GFDL or Thompson microphysics.
Fraction of frozen precipitation with RUC LSM
…may not be allocated
…to merge_gsd_develop_drag_suite_update_and_bugfixes
…nto merge_gsd_develop_drag_suite_update_and_bugfixes
…bles changes the results, this is only true in (CCPP) PROD mode, not in REPRO mode
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
mdtoy
reviewed
Oct 15, 2019
grantfirl
reviewed
Oct 15, 2019
| @@ -395,7 +395,7 @@ subroutine mp_thompson_run(ncol, nlev, con_g, con_rd, & | |||
| graupel = max(0.0, delta_graupel_mp/1000.0_kind_phys) | |||
| ice = max(0.0, delta_ice_mp/1000.0_kind_phys) | |||
| snow = max(0.0, delta_snow_mp/1000.0_kind_phys) | |||
| rain = max(0.0, delta_rain_mp - (delta_graupel_mp + delta_ice_mp + delta_snow_mp)/1000.0_kind_phys) | |||
| rain = max(0.0, (delta_rain_mp - (delta_graupel_mp + delta_ice_mp + delta_snow_mp))/1000.0_kind_phys) | |||
There was a problem hiding this comment.
I'll never forget "Please Excuse My Dear Aunt Sally"...
I bet this was a tough one to catch.
Correct. Grant is looking at removing some of the redundancy between the drag suite pre/post and existing pre/post schemes, and at the b4b differences for the CCPP dynamic build. This will be a separate PR in the future. |
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
Remove nemsio from the write component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PRs:
https://github.com/NCAR/FV3/pull/218
NCAR/NEMS#13
#339
https://github.com/NCAR/NEMSfv3gfs/pull/269
See https://github.com/NCAR/NEMSfv3gfs/pull/269 for regression testing.
Changes for ccpp-physics:
intent(in)to certain variables ingwdps.fchanges the answer; it does so, but only in (CCPP) PROD mode, not in REPRO modephysics/cires_ugwp_post.F90: use assumed-size arrays for arrays that may not be allocated