Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sea_land_ice_mask to sfc_drv_ruc.F90 #334

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Added sea_land_ice_mask to sfc_drv_ruc.F90 #334

merged 2 commits into from
Oct 8, 2019

Conversation

tanyasmirnova
Copy link
Collaborator

The sea_land_ice mask was added to the consistency check on the vegetation type for land points:
if (land(i) .and. (vegtype(i)==iswater .or. (vegtype(i)==isice.and.islimsk(i)==2))) then
!write(errmsg,'(a,i0,a,i0)') 'Logic error in sfc_drv_ruc_run: for i=', i, &
! ', land(i) is true but vegtype(i) is water or ice: ', vegtype(i)
!errflg = 1
!return
if(flag_init .and. iter==1) then
write(0,'(a,i0,a,i0)') 'Warning: in sfc_drv_ruc_run: for i=', i, &
', land(i) is true but vegtype(i) is water or ice: ', vegtype(i)
end if
end if

The vegetation type for ice (isice=15) could be for both land and sea ice points. Therefore, additional check is added to warn only on the sea ice points with land=.true.
This change will preclude from multiple unnecessary warning prints.

@climbfuji climbfuji changed the base branch from master to gmtb/develop October 8, 2019 22:37
@climbfuji climbfuji changed the base branch from gmtb/develop to gsd/develop October 8, 2019 22:38
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This will change the answer for the ccpp_gsd regression tests. The commit is for the gsd/develop branch, not for master, I updated the target branch accordingly.

@climbfuji climbfuji merged commit 8af686d into NCAR:gsd/develop Oct 8, 2019
@climbfuji
Copy link
Collaborator

Note - until we update the submodule pointer for the NEMSfv3gfs gsd/develop branch, these changes won't be included when the code is checked out in the usual way:

git clone --branch=gsd/develop --recursive https://github.com/NCAR/NEMSfv3gfs

@climbfuji
Copy link
Collaborator

Note: this PR includes but does not mention the changes from #332 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants