Added semi-implicit time differencing for turbulent form drag and sma… #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll-scale gravity wave drag schemes -- allows for longer time step
mdtoy
requested review from
climbfuji,
grantfirl,
JulieSchramm and
llpcarson
as code owners
|
@mdtoy this looks ok to me to merge, have you tested the changes (compiled and run)? What timestep did you use? |
|
Hi Dom,
Yes, I compiled it and ran it with a 1200s time step for 48 hours. The
results look good.
— Mike
…On Tuesday, October 8, 2019, Dom Heinzeller ***@***.***> wrote:
@mdtoy <https://github.com/mdtoy> this looks ok to me to merge, have you
tested the changes (compiled and run)? What timestep did you use?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#333?email_source=notifications&email_token=AFMODLB7MUMGEFHKVCIA3K3QNUA7ZA5CNFSM4I6XIG5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAVZEXA#issuecomment-539726428>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFMODLB3NK5PXHY5FLO47X3QNUA7ZANCNFSM4I6XIG5A>
.
--
—————————
Michael Toy
Research Scientist, Model Development Branch
NOAA Earth System Research Lab, GSD
325 Broadway, Boulder, Colorado
Michael.Toy@noaa.gov
+1-303-497-4061 <(303)%20497-4061>
|
|
I am ok merging this without testing it (I will pull it into my upcoming GFSv16 changes for CCPP afterwards anyway and test it there), but I would like to have the OK of one of the other code owners as well. |
|
Sounds good. Thanks.
— Mike
…On Tuesday, October 8, 2019, Dom Heinzeller ***@***.***> wrote:
I am ok merging this without testing it (I will pull it into my upcoming
GFSv16 changes for CCPP afterwards anyway and test it there), but I would
like to have the OK of one of the other code owners as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#333?email_source=notifications&email_token=AFMODLEL7KJJBD4MHOUKB73QNUGT5A5CNFSM4I6XIG5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAV4ONQ#issuecomment-539739958>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFMODLAUIBUTEDQQV3XUNZTQNUGT5ANCNFSM4I6XIG5A>
.
--
—————————
Michael Toy
Research Scientist, Model Development Branch
NOAA Earth System Research Lab, GSD
325 Broadway, Boulder, Colorado
Michael.Toy@noaa.gov
+1-303-497-4061 <(303)%20497-4061>
|
climbfuji
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll-scale gravity wave drag schemes -- allows for longer time step