Convert all schemes to new metadata, bugfixes to sfc_cice, merge gsd/develop, update of CCPP physics with IPD physics changes #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_20190503 gsd/develop merge in master 2019/05/03
gsd/develop: add regression tests for Thompson only, GF only, MYNN only & cleanup
…d support for coldstarting from either Noah LSM or RUC LSM data, temporary interstitial scheme to update Noah-LSM surface fields used by sfc_sice
…ar_update_surface_flux_bugfix_inactive_20190718 gsd/develop: RUC bug fixes, update to initialize from RAP/HRRR data, surface flux bug fix (inactive)
Updating MYNN EDMF and MYNNrad_pre
… to prevent using unconfigured ivegsrc, add check for inconsistent landmask and landuse classification, correctly initialize RUC subsurface data for non-land points for both Noah and RUC input data
…dmask_landuse_inconsistencies Bugfix RUC LSM ice temperature initialization, landmask/landuse inconsistencies
…hat it is consistent with the code in GFS_MP_generic_post_run
…oning address issue NCAR#301
…c unit conversion for cloud effective radii
…nto gmtb_develop_update_from_master_20190830
…to gmtb_develop_update_from_master_20190830
…to_convection) an assumed-shape array
…sol tracer transport for coupled chemistry applications)
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
grantfirl
reviewed
Sep 6, 2019
| @@ -445,7 +445,7 @@ subroutine gw_solver_linsatdis(im, levs, dtp, kdt, me, & | |||
| enddo | |||
|
|
|||
| print * | |||
| pause | |||
| !pause | |||
There was a problem hiding this comment.
Ha! Can't imagine that operations would appreciate that.
grantfirl
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#ifdef GSD_SURFACE_FLUXES_BUGFIXfor a suggested bugfix for the calculation of surface fluxes)See https://github.com/NCAR/NEMSfv3gfs/pull/243 for regression testing.