Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccpp_prebuild: out-of-source builds for parallel cmake builds (target master) #310

Merged
merged 2 commits into from
Oct 31, 2019

Conversation

climbfuji
Copy link
Collaborator

Modifications of CMakeLists.txt to support out-of-source builds, required for parallel cmake builds in NEMSfv3gfs.

Backward compatible for in-source builds for both static and dynamic builds.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Aug 29, 2019

Associated PRs:

NCAR/ccpp-framework#218
#310
https://github.com/NCAR/FV3/pull/215
https://github.com/NCAR/NEMSfv3gfs/pull/264

(previously branches "cmake_rt_gnu_and_ccpp" of gerrit:FV3 and gerrit:NEMSfv3gfs, but these are now out of date)

…ired for parallel cmake builds in NEMSfv3gfs
@climbfuji climbfuji force-pushed the ccpp_prebuild_out_of_source_build branch from db4b64c to 325f9b1 Compare October 10, 2019 02:38
@climbfuji climbfuji changed the title ccpp_prebuild: out-of-source builds for parallel cmake builds ccpp_prebuild: out-of-source builds for parallel cmake builds (target master) Oct 10, 2019
@climbfuji
Copy link
Collaborator Author

This PR is no longer required, however we should keep it for further reference. The changes for the CCPP out of source build are now contained in ufs-community/ufs-weather-model#1 and associated PRs. The changes specific to the cmake_rt approach need to be consolidated with the new cmake version that EMC is working on (based on their separate ongoing efforts) and merged into the new fv3atm and ufs-weather-model repositories.

@climbfuji climbfuji merged commit 3bb41d6 into NCAR:master Oct 31, 2019
@climbfuji climbfuji deleted the ccpp_prebuild_out_of_source_build branch June 27, 2022 03:08
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
Features:
- Implemented sharing of atmospheric tracer metadata (name, units) to coupled model component via a standard NUOPC connector if coupling tracer field is accessed by shared memory reference
- Introduced additional metadata to tracer records in field_table to identify and validate prognostic and diagnostic chemistry tracers. A new record line starting with the `tracer_usage` keyword is now required to recognize chemistry tracer as follows:

      "tracer_usage", "chemistry"                    (default, prognostic)
      "tracer_usage", "chemistry", "type=diagnostic" (diagnostic)

- Added sanity check for input chemistry tracers, ensuring that both prognostic and diagnostic tracers in field_table are contiguous, and diagnostic tracers follow prognostic ones.
- Improved algorithm to set aerosol scavenging factors
- Exported instantaneous fields for:
   - 3D non-convective liquid and ice precipitation fluxes
   - 3D cloud fraction
   - normalized soil wetness
   -  ice fraction (as used in the atmospheric model)
   - lake fraction
   - ocean fraction
   - surface snow area fraction
- Enabled import of diagnostic tracers

Fixes:
- Prevent a divide by zero error when constant arrays are rescaled for lossy compression in `write_netcdf_parallel()`
- Correctly sample and compute elapsed time for field bundle regridding operations.
- Include hotfix (see PR NCAR#308) to allow latest `setup_exportdata()` to work with coupled chemistry.

Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant