Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: use public interface to ccpp_fields_get_ #3

Closed
wants to merge 6 commits into from
Closed

Bug fix: use public interface to ccpp_fields_get_ #3

wants to merge 6 commits into from

Conversation

llpcarson
Copy link
Contributor

Bug fix:

In the gfsphyics IPD_driver_cap.f90 there were two references to
"ccpp_fields_get_ptr":

https://github.com/NCAR/gmtb-gfsphysics/blob/features/ccpp/IPD_layer/IPD_driver_cap.f90

lines 246 & 309.

The subroutine is not public. I (Tim) wrapped it with an interface/module
procedure as ccpp_fields_get() so as to be able to get an int, real,
logical and pointer. We should not be calling the _ptr subroutine.

    modified:   IPD_layer/IPD_driver_cap.f90

@llpcarson
makefile update: list $(OBJS) to create the dynamic library
63b6879
@llpcarson
makefile updates for dynamic lib
1c6fb10
@llpcarson
Merge branch 'features/ccpp' of https://github.com/llpcarson/gmtb-gfs…
4a91d33 
…physics into features/ccpp
@llpcarson
Bug fix:
361031c 
    In the gfsphyics IPD_driver_cap.f90 there were two references to
    "ccpp_fields_get_ptr":

    https://github.com/NCAR/gmtb-gfsphysics/blob/features/ccpp/IPD_layer/IPD_driver_cap.f90

    lines 246 & 309.

    The subroutine is not public. I (Tim) wrapped it with an interface/module
    procedure as ccpp_fields_get() so as to be able to get an int, real,
    logical and pointer. We should not be calling the _ptr subroutine.

        modified:   IPD_layer/IPD_driver_cap.f90
@llpcarson
Merge branch 'features/ccpp' of https://github.com/NCAR/gmtb-gfsphysics…
217189a 
… into features/ccpp
@llpcarson
Corrected call to ccpp_fields_get for PTR type
dde882e 
    modified:   IPD_layer/IPD_driver_cap.f90
@llpcarson
Copy link
Contributor Author

This PR is superceded by Tim's PR (#6)

@llpcarson llpcarson closed this Sep 6, 2017
climbfuji pushed a commit that referenced this pull request Oct 14, 2018
@tanyasmirnova
Merge pull request #3 from climbfuji/ruclsm_dom_mods
c0346d4 
RUC LSM - Dom's mods
climbfuji pushed a commit that referenced this pull request Feb 6, 2019
@joeolson42
Merge pull request #3 from NCAR/master
290e2fb 
updating fork
climbfuji pushed a commit that referenced this pull request Nov 3, 2019
@panll
Merge pull request #3 from NCAR/gmtb/develop
d0f4e50 
Gmtb/develop
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Apr 7, 2020
@junwang-noaa
this PR includes: 1)vlab #69814: post update,2)ufs issue NCAR#3, Add …
e198c52 
…3D reflectivity to restart file and restart reproducibility for regional fv3,3)ufs issue NCAR#5, Updates to WW3, 4)vlab #69735, update netcdf time units attribute when iau_offset
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Apr 7, 2020
@climbfuji
Merge pull request NCAR#3 from climbfuji/ccpp_add_sas_and_satmedmfvdifq
332fb61 
Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) to CCPP
climbfuji pushed a commit that referenced this pull request Jul 2, 2020
@joeolson42
Merge pull request #3 from NOAA-GSD/gsd/develop
46d0200 
updating fork
llpcarson referenced this pull request in llpcarson/ccpp-physics Dec 22, 2020
@tanyasmirnova
Merge pull request #3 from climbfuji/dom_rucice_for_tanya
dccce95 
Suggested changes to rucice PR
climbfuji pushed a commit that referenced this pull request Mar 19, 2021
@pjpegion
Merge pull request #3 from NCAR/master
f60ec02 
merge with NCAR fork
climbfuji pushed a commit that referenced this pull request Apr 26, 2021
@llpcarson
Merge pull request #3 from mzhangw/pr-626
495536d 
scidoc fix for PR626
@gthompsnWRF gthompsnWRF mentioned this pull request Jun 28, 2021
Closed
climbfuji pushed a commit that referenced this pull request Aug 11, 2021
@XiaSun-Atmos
Merge pull request #3 from climbfuji/constant__update_dom_20210802
48e0837 
Constant branch update from Dom 2021/08/02
@mjiacono mjiacono mentioned this pull request Oct 4, 2021
Closed
climbfuji pushed a commit that referenced this pull request Dec 20, 2021
@RuiyuSun
Merge pull request #3 from climbfuji/cloud_cover_xr_dom_20211217
5600c09 
Update cloud_cover_xr with latest change from NCAR ccpp-physics main
grantfirl pushed a commit that referenced this pull request Feb 23, 2022
@JeffBeck-NOAA
Merge pull request #3 from grantfirl/feature/stoch_spp_gjf
f77322b 
Fix the rest of the Cheyenne/GNU tests
AnningCheng-NOAA added a commit that referenced this pull request Apr 5, 2022
@AnningCheng-NOAA
Merge pull request #3 from climbfuji/mraerosol_dom
95c67d3 
Update to mraerosol branch from Dom
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
@tanyasmirnova
Merge pull request NCAR#3 from climbfuji/tanya_gsl_dev_11aug21_lake_dom
fcc7a86 
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
XiaqiongZhou-NOAA pushed a commit to XiaqiongZhou-NOAA/ccpp-physics that referenced this pull request May 30, 2023
@joeolson42
Merge pull request NCAR#3 from grantfirl/mynn_snowfix_gjf
da02a14 
Cray compiler fix
bluefinweiwei pushed a commit to bluefinweiwei/ccpp-physics that referenced this pull request Jul 18, 2023
@MicroTed
Merge pull request NCAR#3 from grantfirl/ufs-dev-tm_gjf
aa433c3 
Revert combination, update to ufs/dev, and update CODEOWNERS
XiaqiongZhou-NOAA pushed a commit to XiaqiongZhou-NOAA/ccpp-physics that referenced this pull request Jul 11, 2024
@Qingfu-Liu
Merge pull request NCAR#3 from grantfirl/HR4-GWD-update_gjf
a949a5f 
Random fixes for HR4 GWD update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@llpcarson