Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for SCM only #295

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Bugfix for SCM only #295

merged 1 commit into from
Aug 14, 2019

Conversation

grantfirl
Copy link
Collaborator

remove loops over nblks in SCM version of GFS_phys_time_vary; no effect on FV3

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has been tested in gmtb/develop for SCM and is required to fix the gmtb-scm master branch. It does not affect NEMSfv3gfs at all, because the file that is changed (GFS_phys_time_vary.scm.F90) is not used by CCPP in NEMSfv3gfs at all. The proposed changes were communicated to EMC and we received the go-ahead.

@grantfirl
Copy link
Collaborator Author

@climbfuji Thanks for communicating with Jun and Dusan at EMC regarding this change.

@grantfirl grantfirl merged commit 2934966 into NCAR:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants