Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccpp_prebuild: out-of-source builds for parallel cmake builds (target master) #218

Merged
merged 4 commits into from
Oct 31, 2019

Conversation

climbfuji
Copy link
Collaborator

Modifications of ccpp_prebuild.py to support out-of-source builds for static CCPP builds, required for parallel cmake builds in NEMSfv3gfs.

Backward compatible for in-source builds for both static and dynamic builds.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Aug 29, 2019

Associated PRs:

#218
NCAR/ccpp-physics#310
https://github.com/NCAR/FV3/pull/215
https://github.com/NCAR/NEMSfv3gfs/pull/264

(previously branches "cmake_rt_gnu_and_ccpp" of gerrit:FV3 and gerrit:NEMSfv3gfs, but these are now out of date)

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some repeated def write methods but otherwise looks okay (as long as my question at the end does not stir up any angst).

def write_sourcefile(self, source_filename):
success = True
filepath = os.path.split(source_filename)[0]
if not os.path.isdir(filepath):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No if filepath here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I will add the guard here as well.

@climbfuji climbfuji changed the title ccpp_prebuild: out-of-source builds for parallel cmake builds ccpp_prebuild: out-of-source builds for parallel cmake builds (target master) Aug 30, 2019
@climbfuji
Copy link
Collaborator Author

This PR is no longer required, however we should keep it for further reference. The changes for the CCPP out of source build are now contained in ufs-community/ufs-weather-model#1 and associated PRs. The changes specific to the cmake_rt approach need to be consolidated with the new cmake version that EMC is working on (based on their separate ongoing efforts) and merged into the new fv3atm and ufs-weather-model repositories.

@climbfuji climbfuji merged commit 1358ecf into NCAR:master Oct 31, 2019
@climbfuji climbfuji deleted the ccpp_prebuild_out_of_source_build branch June 27, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants