Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constituents object using wrong standard name #587

Open
nusbaume opened this issue Sep 5, 2024 · 0 comments
Open

Constituents object using wrong standard name #587

nusbaume opened this issue Sep 5, 2024 · 0 comments
Assignees
Labels

Comments

@nusbaume
Copy link
Collaborator

nusbaume commented Sep 5, 2024

Description

Currently when the CCPP constituents object is determining what the mixing ratio water type should be (e.g. dry, moist, or wet) it looks for certain strings in the constituent's standard name.

However, for the wet setting it is looking for wrt_total_mass, which according to the CCPP Standard Names dictionary has been replaced with wrt_moist_air_and_condensed_water. This is resulting in constituent variables being given the wrong properties in the constituents object even when using the correct standard name.

Steps to Reproduce

Create a constituent variable with the standard name suffix wrt_moist_air_and_condensed_water. Then check that constituent's is_wet property, which should be .true. but will instead be .false..

One can also look at the constituent object logic being applied in the code block here:

https://github.com/NCAR/ccpp-framework/blob/main/src/ccpp_constituent_prop_mod.F90#L425

Additional Context

Not a critical priority, at least for SIMA, but it could certainly result in a host model generating incorrect results in a way that could be quite difficult to track down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants