Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/properties always returns json format #339

Closed
tloubrieu-jpl opened this issue May 23, 2023 · 1 comment · Fixed by #409
Closed

/properties always returns json format #339

tloubrieu-jpl opened this issue May 23, 2023 · 1 comment · Fixed by #409
Assignees
Labels
B14.0 bug Something isn't working open.v1.3.1 open.v1.4.0 open.1.4.0 s.medium Medium level severity

Comments

@tloubrieu-jpl
Copy link
Member

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When I did request:

'''
curl -X 'GET'
'http://localhost:8081/properties'
-H 'accept: application/csv'
'''

I am getting a json response.

Whatever the Accept header value, we are getting a json response.

🕵️ Expected behavior

I expected either to get a response in the requested format or an unsupported format error (406)

📜 To Reproduce

  1. Deploy from main branch
  2. run curl request above

🖥 Environment Info

Tested with a server deployed on my latptop, build from the source.

📚 Version of Software Used

Tested with the latest main branch (v1.3.0-SNAPSHOT)

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

@tloubrieu-jpl
Copy link
Member Author

I believe this ticket is linked to management of the response format in the openapi specification and another consequence is the following bug on the python api client NASA-PDS/pds-api-client#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B14.0 bug Something isn't working open.v1.3.1 open.v1.4.0 open.1.4.0 s.medium Medium level severity
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

3 participants