Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: VO unit warnings when running the notebooks #94

Open
zoghbi-a opened this issue Nov 11, 2022 · 1 comment
Open

BUG: VO unit warnings when running the notebooks #94

zoghbi-a opened this issue Nov 11, 2022 · 1 comment
Assignees
Labels
content Issues regarding the content of the notebooks

Comments

@zoghbi-a
Copy link
Contributor

Running some cells in the notebooks produce warnings:

WARNING: UnitsWarning: Unit 'degree' not supported by the VOUnit standard.  [astropy.units.format.vounit]
WARNING: UnitsWarning: Unit 'mjd' not supported by the VOUnit standard. Did you mean MD, MJ, Md, mD, mJ or md? [astropy.units.format.vounit]

Some are already filtered by including filters at the top (e.g. warnings.filterwarnings('ignore', '.*Unknown element .*', vo.utils.xml.elements.UnknownElementWarning)). Others are related to the units in some services not being proper VOUnits (the above two example), and they show up in the rendered notebooks (e.g. here).

This issue is to open discussion about how they should be handled.

This is a quote from @bsipocz copied from slack:

I still strongly feel that pedagogically we should not add filterwarnings into user notebooks but rather show how to fix those units. That being said, something is clearly broken with the current solution.

@bsipocz bsipocz self-assigned this Dec 5, 2022
@bsipocz bsipocz changed the title Warnings when running the notebooks BUG: VO unit warnings when running the notebooks Dec 5, 2022
@bsipocz
Copy link
Contributor

bsipocz commented Dec 5, 2022

During the last call I volunteered that I'll add a cell for the notebooks that see this issue to show how to override the non VO-compliant units as opposed to automatically filter all of these warnings (btw, that filter should work, but it doesn't so this is also a bug)

@bsipocz bsipocz added the content Issues regarding the content of the notebooks label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues regarding the content of the notebooks
Projects
None yet
Development

No branches or pull requests

2 participants