Check constraint violations on a specific simulationDatasetId if present

[skovati]

Related problems

After merging #976, the constraintViolations Hasura action now accepts an optional simulationDatasetId. However, this ID only filters the external datasets included in constraint checking, not the simulation results used for checking (which still defaults to the latest simulation).

Describe the feature request

If the sim dataset ID is provided, it would be beneficial to check constraints for that specific simulation dataset ID. This would enable constraint checking on historical simulation results, rather than solely relying on the latest one.

aerie/merlin-server/src/main/java/gov/nasa/jpl/aerie/merlin/server/services/GetSimulationResultsAction.java

Line 124 in 4de9ebd

public List<Violation> getViolations(final PlanId planId, final Optional<SimulationDatasetId> simulationDatasetId)

should be changed to retrieve the passed simulationDatasetId if it's nonempty; otherwise, retain the current behavior of defaulting to the latest simulation.

[skovati]

Closed by #1013