-
Notifications
You must be signed in to change notification settings - Fork 295
Adding vehicle icons & brand information #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes last_modified types from string to date
gbfs.md
Outdated
@@ -350,6 +350,12 @@ Field Name | REQUIRED | Type | Defines | |||
`license_url` | Conditionally REQUIRED <br/>*(as of v3.0-RC)* | URL | REQUIRED if the dataset is provided under a customized license. A fully qualified URL of a page that defines the license terms for the GBFS data for this system. Do not specify a `license_url` if `license_id` is specified. If the `license_id` and `license_url` fields are blank or omitted, this indicates that the feed is provided under the [Creative Commons Universal Public Domain Dedication](https://creativecommons.org/publicdomain/zero/1.0/legalcode). *(as of v3.0-RC)* | |||
`attribution_organization_name` <br/>*(added in v3.0-RC)* | OPTIONAL | String | If the feed license requires attribution, name of the organization to which attribution should be provided. | |||
`attribution_url` <br/>*(added in v3.0-RC)* | OPTIONAL | URL | URL of the organization to which attribution should be provided. | |||
`brand_assets` | Optional | Object | An object where each key defines on of the items listed below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: on
-> one
.
Hi! Looking forward to having brand assets as part of the standard! I am a bit skeptical to the proposed properties on We are developing client apps that consume GBFS feeds from different systems and display them in a map. We want a consistent design on these that match our own design. I don't think we would or could rely on the icons provided by the feed providers for such a use case. The system brand assets are OK, since they are "objective, universal facts" tied to the data (provider), no matter how things are displayed in consuming apps. You cannot argue that Lime's logo is Lime's logo, etc. The icons on the other hand are more related to design than data. And the desired design of applications and display of vehicles/stations will vary for every application. The specification can also be misunderstood: "A fully qualified URL pointing to the location of a graphic icon file to be used to represent this vehicle type on maps and in other applications". Does this mean that I, as an app developer, MUST use the specified Suggestion: Don't add the proposed icon properties to Adding @kanagy's original propsal for these props from #317 here:
|
Fixes typo adn clarifies OPTIONAL use of vehicle type icons
I agree that data consumers might prefer to decide how to represent vehicles in their applications as opposed to using graphics supplied by the publishers, however this proposal comes about in response to requests from data consumers for these assets so there's reason to believe that they will be used. On the consuming side, whether or not to use these assets is optional. I've updated the definition of
As a data consumer you can choose to use them or not, as is true with most everything in the specification. |
We currently cutomize vehicle or station icons on the map for ridesharing and some GBFS integrations. AFAIK this is because producers tend to care about branding - customizing their experience and visually distinguishing it from other competitiors listed. I can also think of a use-case which shows a map with all the available providers around you; here it might be useful to visually distinguish vehicles and stations beyond just using the brand color. It does add a layer of complexity though - e.g. checking if the icon plays well with the consumer app scheme. Are there other consumers that are interested in these icons? We'll discuss this more internally. In meantime, I suggest also wrapping the vehicle type assets into a brand_assets message. |
Are you suggesting something like this? "vehicle_assets" : { |
Yes. |
Adds wrapper object vehicle_assets to
I've wrapped the icon fields in vehicle_types in a vehicle_assets object per @kanagy's suggestion. |
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on September 1st, 2021. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
Google Maps supports this and intends on using these fields (initially to just manually get, check and ingest the assets). |
+1 from Stae |
So to represent free floating vehicles, consumers shall display the icon of the corresponding vehicle type. But how are stations (with potentially vehicles of multiple types) supposed to be pictured? |
@nbdh use of these icons would be optional, so it's up to the consumer to decide how they want to display the data. In the case of a station the vehicle icons could be used to show the number of each type of vehicle at the station. Selecting a station would display the icons for each vehicle type and their respective totals. We could also add a |
This seems sensible, though this opens many more questions. Will the So from my point of view this seems rather like a start in the "branding and icons" topic that probably needs to be extended at some point. Nonetheless we support the proposal, though I can't tell when we will start publishing this info. |
Dott supports this proposal, might implement this in the future. |
Entur supports this proposal and will implement it in our aggregation service |
IBI Group supports this proposal. |
Spin support this proposal. We currently advertise some assets, so we likely will implement this and update our feeds to match this standard. |
Superpedestrian supports this proposal and will implement it. |
This vote is now closed, and it passes! Votes in favour: There we no votes against. These changes will be merged into a v2.3-RC pending implementation. |
Changes brand asset terms_url to brand_terms_url to avoid conflict with terms of use terms_url
What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.
Currently the specification lacks any type of branding assets or ways to graphically represent vehicles. Some consuming applications have expressed a need for Icons and/or other brand related information to represent the mobility services that they aggregate.
What is the proposal?
This proposal adds fields to
system_information.json
andvehicle_types.json
to support brand information and vehicle icons. This issue has been discussed in #317. I have modified some of the field names to increase readability and avoid confusion between the endpoints. I also added a last modified field for both brand assets and vehicle icons. This data is important for consuming applications that cache images so that cached images aren't out of date. We discussed other ways of handling modification dates but none of them seemed as reliable as the addition of dedicated fields.Is this a breaking change?
Which files are affected by this change?
gbfs.md: