Skip to content

Commit 9ab6481

Browse files
committed
build: improve make clean
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs#16372 Refs: nodejs#16010 Refs: nodejs#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2be9198 commit 9ab6481

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Makefile

+5-1
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,15 @@ uninstall:
102102

103103
clean:
104104
$(RM) -r out/Makefile $(NODE_EXE) $(NODE_G_EXE) out/$(BUILDTYPE)/$(NODE_EXE) \
105-
out/$(BUILDTYPE)/node.exp
105+
out/$(BUILDTYPE)/node.exp
106106
@if [ -d out ]; then find out/ -name '*.o' -o -name '*.a' -o -name '*.d' | xargs $(RM) -r; fi
107107
$(RM) -r node_modules
108108
@if [ -d deps/icu ]; then echo deleting deps/icu; $(RM) -r deps/icu; fi
109109
$(RM) test.tap
110+
# Next one is legacy remove this at some point
111+
$(RM) -r test/tmp*
112+
$(RM) -r test/.tmp*
113+
$(MAKE) test-addons-clean
110114

111115
distclean:
112116
$(RM) -r out

vcbuild.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ echo Failed to create vc project files.
541541
goto exit
542542

543543
:help
544-
echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
544+
echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
545545
echo Examples:
546546
echo vcbuild.bat : builds release build
547547
echo vcbuild.bat debug : builds debug build

0 commit comments

Comments
 (0)