Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Yarn #1334

Closed
dternyak opened this issue Mar 16, 2018 · 4 comments
Closed

Default to Yarn #1334

dternyak opened this issue Mar 16, 2018 · 4 comments
Labels
type: discussion Items that are primarily a discussion around a feature or issue. May evolve to be actionable.

Comments

@dternyak
Copy link
Contributor

dternyak commented Mar 16, 2018

Points to consider:

  1. electron-builder recommends yarn (TODO: find source)
  2. yarn has supposed security benefits (TODO: find source)
  3. yarn is more performant than npm (TODO: find source)
@dternyak dternyak added type: discussion Items that are primarily a discussion around a feature or issue. May evolve to be actionable. tech/research labels Mar 17, 2018
@skubakdj
Copy link
Contributor

  1. The NPM page for electron-builder has the brief statement

Yarn is strongly recommended instead of npm.

which links out to this issue as an explanation.

  1. Here's a neat article from last December comparing the two. Quoting its section on security:

A major problem with npm is that it automatically runs code from dependencies and permits packages to be added on the fly, While this feature comes with its conveniences, it also creates security vulnerabilities. Since Yarn only installs from your yarn.lock or package.json files, it’s considered to be more secure, which is increasingly important in today’s world. Yarn also makes use of checksums before installation to ensure the integrity of each package.

  1. Here's a Medium post by Netscape comparing performance. Yarn comes out ahead of NPM. In my experience, I've found Yarn to be significantly faster than NPM when doing a fresh install of node modules.

@HenryNguyen5
Copy link

Don't really agree with the security article now that npm5 is default, there shouldn't be any difference security wise. Definitely agree with the performance boost though, and yarn having its own offline cache helps a lot on intermittent internet connections.

@HenryNguyen5
Copy link

Currently encountering this issue with yarn at times: nodejs/node-gyp#809 (comment)

@SharonManrique
Copy link
Contributor

Added to Asana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Items that are primarily a discussion around a feature or issue. May evolve to be actionable.
Projects
None yet
Development

No branches or pull requests

6 participants