Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When checkout is a hash, some messages could be better #14

Open
MurphyMc opened this issue Jul 17, 2020 · 0 comments
Open

When checkout is a hash, some messages could be better #14

MurphyMc opened this issue Jul 17, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@MurphyMc
Copy link
Owner

@AbePralle has a gist which shows some unhelpful messages.

These all revolve around a case where the repo's checkout is a specific commit.

  • For example on line line 14/16, it looks like the advice here is slightly wrong. It suggests checking out the commit directly, but depz should have created a branch for that commit. I think you should probably check that out.
  • Bonus: We should probably have a sanity check where if the current branch is checkout_<hash>, the HEAD should actually be the given hash!
  • On line 34/39, it's doing do_show_outdated and complains that it can't tell. There's a special case if the checkout is a tag, since a tag can't be outdated. I think we should attempt to apply similar logic when the checkout is a specific commit. If there are monitored branches, we should check them, but if there aren't, we should just assume things are okay (as long as the checkout commit is in the ancestors of HEAD).
  • On line 35/40... this one is debatable. The warning might be fine, and the repo should just be configured with fast_forward_skip. I think that's probably best. (One could argue that if the checkout is a hash, we should just skip it, but for a couple reasons, I don't like this as well.)
@MurphyMc MurphyMc added the enhancement New feature or request label Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant