Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strokOrder instead of _strokeOrder #17

Closed
Aaron2464 opened this issue Oct 21, 2020 · 2 comments · Fixed by #16
Closed

Use strokOrder instead of _strokeOrder #17

Aaron2464 opened this issue Oct 21, 2020 · 2 comments · Fixed by #16

Comments

@Aaron2464
Copy link
Contributor

Line 365 in strokeOrderAnimationController.dart file
void setStrokeOrder(String strokeOrder) { final parsedJson = json.decode(_strokeOrder.replaceAll("'", '"')); }

Could it use strokOrder instead of _strokeOrder? Plz
void setStrokeOrder(String strokeOrder) { final parsedJson = json.decode(strokeOrder.replaceAll("'", '"')); }

I'd like to change strokeOrder after I get data from internet.

@Mr-Pepe Mr-Pepe linked a pull request Oct 21, 2020 that will close this issue
Mr-Pepe added a commit that referenced this issue Oct 23, 2020
@Mr-Pepe
Copy link
Collaborator

Mr-Pepe commented Oct 23, 2020

Landed in version 1.6.1 :)

@Aaron2464
Copy link
Contributor Author

Thank you so much. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants