Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add ping for telemetry enable/disable #1477

Closed
philip-lamb opened this issue Jul 30, 2019 · 14 comments · Fixed by #1936
Closed

Add ping for telemetry enable/disable #1477

philip-lamb opened this issue Jul 30, 2019 · 14 comments · Fixed by #1936
Assignees
Labels
enhancement This issue is a new feature or request telemetry
Milestone

Comments

@philip-lamb
Copy link
Contributor

We don't have a clear idea of what percentage of users disable telemetry. When a user elects to disable it, we should transmit a "goodbye" ping, and conversely a "hello" ping when a user enables the function.

This will help gauge user sentiment around collecting data to improve the browser.

@philip-lamb philip-lamb added enhancement This issue is a new feature or request P3 Backlog labels Jul 30, 2019
@philip-lamb
Copy link
Contributor Author

requires #561

@philip-lamb philip-lamb added this to the v1.x milestone Jul 30, 2019
@philip-lamb
Copy link
Contributor Author

@jvonitter It'd be good to pull this into 1.5 as part of our telemetry boost.

@jvonitter jvonitter modified the milestones: v1.x, v1.5 Aug 20, 2019
@jvonitter
Copy link
Contributor

@keianhzo
Copy link
Contributor

keianhzo commented Oct 8, 2019

@jvonitter the PR is ready for review. Shouldn't be merged before the data review is approved though.

@jvonitter
Copy link
Contributor

From Manuel:
I got some info about how to implement it from the Telemetry team. They pointed out a couple of things though:

  • They were concern about sending a ping after the the user opts out, we need to really justify the need of this so we can pass the data review
  • It seems that some sort of user information is sent with the event ping so we will be able to group by user through backend queries
  • They told me that there is always a discrepancy between our telemetry and external sources and trying to hard to fill the gap might be a time sink and lead nowhere: “In general things never match with external data sources” (edited)

@jvonitter
Copy link
Contributor

Moving this into 6 so we can consider the feedback and figure out the right path.

@jvonitter jvonitter modified the milestones: #5 polish, #6 features Oct 8, 2019
@keianhzo
Copy link
Contributor

keianhzo commented Oct 9, 2019

Data review form, attn @harraton
datareview-telemetry-status.txt

  • Wiki updated

@philip-lamb
Copy link
Contributor Author

Link to ping used for this purpose on desktop: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/optout-ping.html

@keianhzo
Copy link
Contributor

keianhzo commented Oct 10, 2019

@philip-lamb I talked to the Telemetry team before implementing this and they recommended using an event ping vs the opt-out ping as we can group pings by user:

@manuel.martin so what I’m saying is if you send an event, or tack it on the settings of the event ping we can group by user, if we use the opt-out ping we cannot

@keianhzo
Copy link
Contributor

@harraton Any updates on this?

@harraton
Copy link
Contributor

Data Review Form

Instructions: Data Stewards will review a request for data collection and endorse responses to each question. If the request does not provide answers to questions, reviewers give an r- and point to the questions that can’t be answered.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes (Wiki)

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, there is a telemetry switch. This new data allows the team to understand if that switch has been turned to On or Off.

  3. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Category 2.

  4. Is the data collection request for default-on or default-off?
    Default-On

  5. Does the instrumentation include the addition of any new identifiers.
    No.

  6. Is the data collection covered by the existing Firefox privacy notice?
    Covered by the Firefox Reality Privacy Notice.

  7. Does there need to be a check-in in the future to determine whether to renew the data? Yes

  8. Does the data collection use a third-party collection tool?
    No.

@harraton
Copy link
Contributor

Ping approved.

@keianhzo
Copy link
Contributor

@jvonitter The Telemetry wiki page has been updated.

@jvonitter
Copy link
Contributor

I've set a reminder to check on this in 6 months to see if we still need to collect the data. We're ok to merge this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue is a new feature or request telemetry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants