Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a second locale to both the Django unit test suite, and our load_fake_data factory code #7559

Closed
Pomax opened this issue Oct 4, 2021 · 3 comments · Fixed by #7836
Closed
Assignees

Comments

@Pomax
Copy link
Contributor

Pomax commented Oct 4, 2021

Follow-up to #7502

We need to add a secondary locale as part of the test framework before can write tests that can verify that changes are correct across locales. (For PNI specifically, we also want to know that votes on localized objects make it to the original object, etc).

@benhohner
Copy link
Contributor

@richbrennan feel free to reach out to @Pomax for any questions or further clarification on this one!

@jamilasnell
Copy link

Hey @richbrennan ! Is this still an 8? If not, can you please re-estimate? Thank you!

@richbrennan
Copy link
Contributor

I've put this down to a 1 for this sprint as there should hopefully only be a small change needed, depending on answer to outstanding question on PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants