Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events for sortEnd and updateComplete are never triggered after a sortStart if a table is empty #532

Closed
jonsa opened this issue Mar 5, 2014 · 3 comments
Labels

Comments

@jonsa
Copy link

jonsa commented Mar 5, 2014

The fix for issue #206 and #346 returns from appendToTable without triggering sortEnd and updateComplete.

Because of this there is no equilibrium between the triggered events. This is troublesome particularly if you, like me, is listening for sortStart to show a loader and remove it on sortEnd.

@Mottie
Copy link
Owner

Mottie commented Mar 5, 2014

Hi @jonsa!

Thanks for reporting this, I'll look into it and have it fixed in the next update.

@jonsa
Copy link
Author

jonsa commented Mar 5, 2014

Here is a reduced fiddle showing it in action. Empty the table and the output-container has sortBegin instead of sortEnd

@Mottie Mottie added the Bug label Mar 5, 2014
@Mottie Mottie closed this as completed in 474e446 Mar 7, 2014
@Mottie
Copy link
Owner

Mottie commented Mar 7, 2014

Hi @jonsa!

This update fixes the problem; but, I have noticed that when updating a table, the "updateComplete" event fires before "sortEnd" when using pager ajax. It would take a bit more work to get this in order, but I'm not if that essential. So I'll see if there are any requests for it before I devote more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants