Merge pull request #12 from MortarStone/deb/stringify_response

Stringify response

Author: debok

Gemfile.lock

@@ -3,112 +3,135 @@ PATH
   specs:
     deka (0.0.1)
       activemodel
-      activesupport
       dotenv
-      faraday (>= 1.0)
+      faraday (>= 1.0, < 2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (7.1.3.4)
-      activesupport (= 7.1.3.4)
-    activesupport (7.1.3.4)
+    activemodel (8.0.1)
+      activesupport (= 8.0.1)
+    activesupport (8.0.1)
       base64
+      benchmark (>= 0.3)
       bigdecimal
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+      concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      mutex_m
-      tzinfo (~> 2.0)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     ast (2.4.2)
     base64 (0.2.0)
-    bigdecimal (3.1.8)
+    benchmark (0.4.0)
+    bigdecimal (3.1.9)
     coderay (1.1.3)
-    concurrent-ruby (1.3.3)
-    connection_pool (2.4.1)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.0)
     crack (1.0.0)
       bigdecimal
       rexml
-    diff-lcs (1.5.1)
-    docile (1.4.0)
-    dotenv (3.1.2)
+    diff-lcs (1.6.0)
+    docile (1.4.1)
+    dotenv (3.1.7)
     drb (2.2.1)
-    factory_bot (6.4.6)
-      activesupport (>= 5.0.0)
-    faraday (2.10.0)
-      faraday-net_http (>= 2.0, < 3.2)
-      logger
-    faraday-net_http (3.1.0)
-      net-http
+    factory_bot (6.5.1)
+      activesupport (>= 6.1.0)
+    faraday (1.10.4)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-httpclient (~> 1.0)
+      faraday-multipart (~> 1.0)
+      faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.0)
+      faraday-patron (~> 1.0)
+      faraday-rack (~> 1.0)
+      faraday-retry (~> 1.0)
+      ruby2_keywords (>= 0.0.4)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-httpclient (1.0.1)
+    faraday-multipart (1.1.0)
+      multipart-post (~> 2.0)
+    faraday-net_http (1.0.2)
+    faraday-net_http_persistent (1.2.0)
+    faraday-patron (1.0.0)
+    faraday-rack (1.0.0)
+    faraday-retry (1.0.3)
     hashdiff (1.1.2)
-    i18n (1.14.5)
+    i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.7.2)
-    language_server-protocol (3.17.0.3)
-    logger (1.6.0)
+    json (2.10.1)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    logger (1.6.6)
     method_source (1.1.0)
-    minitest (5.24.1)
-    mutex_m (0.2.0)
-    net-http (0.4.1)
-      uri
-    parallel (1.25.1)
-    parser (3.3.4.0)
+    minitest (5.25.4)
+    multipart-post (2.4.1)
+    parallel (1.26.3)
+    parser (3.3.7.1)
       ast (~> 2.4.1)
       racc
-    pry (0.14.2)
+    pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     public_suffix (6.0.1)
-    racc (1.8.0)
+    racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
-    regexp_parser (2.9.2)
-    rexml (3.3.2)
-      strscan
+    regexp_parser (2.10.0)
+    rexml (3.4.1)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.0)
+    rspec-core (3.13.3)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.1)
+    rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.1)
+    rspec-mocks (3.13.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.1)
-    rubocop (1.65.0)
+    rspec-support (3.13.2)
+    rubocop (1.72.2)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.4, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.3)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.38.0)
       parser (>= 3.3.1.0)
     ruby-progressbar (1.13.0)
+    ruby2_keywords (0.0.5)
+    securerandom (0.4.1)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
-    simplecov-html (0.12.3)
+    simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    strscan (3.1.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.5.0)
-    uri (0.13.0)
-    vcr (6.2.0)
-    webmock (3.24.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    uri (1.0.2)
+    vcr (6.3.1)
+      base64
+    webmock (3.25.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)

deka.gemspec

@@ -30,8 +30,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'activemodel'
-  spec.add_dependency 'activesupport'
   spec.add_dependency 'dotenv'
-  spec.add_dependency 'faraday', '>= 1.0'
+  spec.add_dependency 'faraday', '>= 1.0', '< 2.0'
   spec.metadata['rubygems_mfa_required'] = 'true'
 end

examples/helper.rb

@@ -24,7 +24,7 @@ def print_no_access_message
 def print_list(object_name, pk_id_name, response)
   print_headers(response.headers)
 
-  list = response.body[:data]
+  list = response.body['data']
   if list.nil? || list.empty?
     puts 'Nothing found'
   else
@@ -62,7 +62,7 @@ def print_row(index, item, column_headers)
 def print_item(object_name, response)
   print_headers(response.headers)
 
-  item = response.body[:data]
+  item = response.body['data']
   puts
   if item.nil?
     puts "Item not found"

examples/helpers/families.rb

@@ -7,12 +7,12 @@ def print_family(item)
 end
 
 def family_columns
-  [
-    :id,
-    :name,
-    :primary_contact,
-    :created_at,
-    :updated_at,
-    :deleted_at
+  %w[
+    id
+    name
+    primary_contact
+    created_at
+    updated_at
+    deleted_at
   ]
 end

examples/helpers/organizations.rb

@@ -7,19 +7,19 @@ def print_organization(item)
 end
 
 def organization_columns
-  [
-    :id,
-    :uuid,
-    :org_name,
-    :email,
-    :slug,
-    :phone,
-    :mobile,
-    :address,
-    :city,
-    :state_province,
-    :postal,
-    :created_at,
-    :updated_at
+  %w[
+    id
+    uuid
+    org_name
+    email
+    slug
+    phone
+    mobile
+    address
+    city
+    state_province
+    postal
+    created_at
+    updated_at
   ]
 end

examples/helpers/purposes.rb

@@ -7,12 +7,12 @@ def print_purpose(item)
 end
 
 def purpose_columns
-  [
-    :id,
-    :name,
-    :active,
-    :created_at,
-    :updated_at,
-    :deleted_at
+  %w[
+    id
+    name
+    active
+    created_at
+    updated_at
+    deleted_at
   ]
 end

examples/helpers/transactions.rb

@@ -7,16 +7,16 @@ def print_transaction(item)
 end
 
 def transaction_columns
-  [
-    :id,
-    :payment_type,
-    :purpose_id,
-    :status,
-    :amount,
-    :user_id,
-    :date,
-    :created_at,
-    :updated_at,
-    :deleted_at
+  %w[
+    id
+    payment_type
+    purpose_id
+    status
+    amount
+    user_id
+    date
+    created_at
+    updated_at
+    deleted_at
   ]
 end

examples/helpers/users.rb

@@ -7,13 +7,13 @@ def print_user(item)
 end
 
 def user_columns
-  [
-    :id,
-    :family_id,
-    :first_name,
-    :last_name,
-    :created_at,
-    :updated_at,
-    :deleted_at
+  %w[
+    id
+    family_id
+    first_name
+    last_name
+    created_at
+    updated_at
+    deleted_at
   ]
 end

lib/deka/response.rb

@@ -24,7 +24,7 @@ def self.from_http_response(http_response)
     def self.parse_body(response_body)
       return if response_body.empty?
 
-      JSON.parse(response_body, symbolize_names: true) rescue response_body
+      JSON.parse(response_body) rescue response_body
     end
 
     def error_message

spec/deka/endpoints/families_spec.rb

@@ -8,12 +8,12 @@
     end
 
     it 'returns an array' do
-      expect(@families[:data]).to be_an(Array)
+      expect(@families['data']).to be_an(Array)
     end
 
     it 'returns family objects' do
-      expect(@families[:data].first).to be_a(Hash)
-      expect(@families[:data].first[:id]).to_not be_nil
+      expect(@families['data'].first).to be_a(Hash)
+      expect(@families['data'].first['id']).to_not be_nil
     end
   end
 
@@ -24,8 +24,8 @@
     end
 
     it 'returns a user_family object' do
-      expect(@user_family[:data]).to be_a(Hash)
-      expect(@user_family[:data][:id]).to eq(610)
+      expect(@user_family['data']).to be_a(Hash)
+      expect(@user_family['data']['id']).to eq(610)
     end
   end
 end

spec/deka/endpoints/organizations_spec.rb

@@ -10,8 +10,8 @@
     end
 
     it 'returns a organization object' do
-      expect(@organization[:data]).to be_a(Hash)
-      expect(@organization[:data][:id]).to eq(118)
+      expect(@organization['data']).to be_a(Hash)
+      expect(@organization['data']['id']).to eq(118)
     end
   end
 end