Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On fail, create comment #119

Closed
bryantbiggs opened this issue Sep 21, 2020 · 2 comments
Closed

On fail, create comment #119

bryantbiggs opened this issue Sep 21, 2020 · 2 comments
Assignees
@MorrisonCole

Comments

@bryantbiggs
Copy link
Contributor

Great action btw! It would be nice to have the ability to create just a comment as opposed to requesting changes since requesting changes will block workflows (potentially). We want to nudge users to follow a certain PR title but it is not applicable in 100% of the scenarios (say JIRA ticket pattern in the title for example). So in those 1% of the cases, we'd like the action still to nudge them but not block entirely. Anyways, food for thought!
@MorrisonCole MorrisonCole self-assigned this Oct 7, 2020
@MorrisonCole
Copy link
Owner

Done courtesy of @bryantbiggs with #121 🎉

@MorrisonCole
Copy link
Owner

@bryantbiggs - just released this with https://github.com/MorrisonCole/pr-lint-action/releases/tag/v1.4.0!

I changed the flag name a little so if you were using your branch while you were waiting, please be aware of that! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MorrisonCole MorrisonCole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MorrisonCole @bryantbiggs